Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbcDTTnO (ORCPT ); Wed, 20 Apr 2016 15:43:14 -0400 Received: from mail-ig0-f179.google.com ([209.85.213.179]:38028 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbcDTTnM (ORCPT ); Wed, 20 Apr 2016 15:43:12 -0400 Reply-To: ahs3@redhat.com Subject: Re: [PATCH] char: Drop bogus dependency of DEVPORT on !M68K References: <1460364055-10174-1-git-send-email-geert@linux-m68k.org> To: Geert Uytterhoeven , Arnd Bergmann , Greg Kroah-Hartman Cc: Geoff Levand , linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org From: Al Stone Organization: Red Hat, Inc. Message-ID: <5717DBCE.2000303@redhat.com> Date: Wed, 20 Apr 2016 13:43:10 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1460364055-10174-1-git-send-email-geert@linux-m68k.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 47 On 04/11/2016 02:40 AM, Geert Uytterhoeven wrote: > According to full-history-linux commit d3794f4fa7c3edc3 ("[PATCH] M68k > update (part 25)"), port operations are allowed on m68k if CONFIG_ISA is > defined. > > However, commit 153dcc54df826d2f ("[PATCH] mem driver: fix conditional > on isa i/o support") accidentally changed an "||" into an "&&", > disabling it completely on m68k. This logic was retained when > introducing the DEVPORT symbol in commit 4f911d64e04a44c4 ("Make > /dev/port conditional on config symbol"). > > Drop the bogus dependency on !M68K to fix this. > > Fixes: 153dcc54df826d2f ("[PATCH] mem driver: fix conditional on isa i/o support") > Signed-off-by: Geert Uytterhoeven > --- > drivers/char/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig > index d3b8ddc6241cac2d..fa56bc757fe98fd1 100644 > --- a/drivers/char/Kconfig > +++ b/drivers/char/Kconfig > @@ -585,7 +585,6 @@ config TELCLOCK > > config DEVPORT > bool > - depends on !M68K > depends on ISA || PCI > default y > > This solves the particular problem I was running into on an arm64 AMD Seattle system. Thanks! Tested-by: Al Stone -- ciao, al ----------------------------------- Al Stone Software Engineer Red Hat, Inc. ahs3@redhat.com -----------------------------------