Date: Wed, 20 Apr 2016 15:43:13 -0400
From: Tejun Heo <tj@kernel.org>
To: serge.hallyn@ubuntu.com
Cc: linux-kernel@vger.kernel.org, adityakali@google.com,
        linux-api@vger.kernel.org, containers@lists.linux-foundation.org,
        cgroups@vger.kernel.org, akpm@linux-foundation.org,
        ebiederm@xmission.com, gregkh@linuxfoundation.org, lizefan@huawei.com,
        hannes@cmpxchg.org
Subject: Re: [PATCH 1/2] kernfs_path_from_node_locked: don't overwrite nlen
Message-ID: <20160420194313.GA4775@htj.duckdns.org>
References: <1460923472-29370-1-git-send-email-serge.hallyn@ubuntu.com>
 <1460923472-29370-2-git-send-email-serge.hallyn@ubuntu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1460923472-29370-2-git-send-email-serge.hallyn@ubuntu.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 963
Lines: 26

On Sun, Apr 17, 2016 at 03:04:31PM -0500, serge.hallyn@ubuntu.com wrote:
> From: Serge Hallyn <serge.hallyn@ubuntu.com>
> 
> We've calculated @len to be the bytes we need for '/..' entries from
> @kn_from to the common ancestor, and calculated @nlen to be the extra
> bytes we need to get from the common ancestor to @kn_to.  We use them
> as such at the end.  But in the loop copying the actual entries, we
> overwrite @nlen.  Use a temporary variable for that instead.
> 
> Without this, the return length, when the buffer is large enough, is
> wrong.  (When the buffer is NULL or too small, the returned value is
> correct. The buffer contents are also correct.)
> 
> Interestingly, no callers of this function are affected by this as of
> yet.  However the upcoming cgroup_show_path() will be.
> 
> Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>

Acked-by: Tejun Heo <tj@kernel.org>

Greg, can you please pick this one up for v4.6?

Thanks.

-- 
tejun