Date: Wed, 20 Apr 2016 13:19:55 -0700
From: Darren Hart <dvhart@infradead.org>
To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= 
	<giedrius.statkevicius@gmail.com>
Cc: corentin.chary@gmail.com, acpi4asus-user@lists.sourceforge.net,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] asus-laptop: correct error handling in
 sysfs_acpi_set
Message-ID: <20160420201955.GA35572@f23x64.localdomain>
References: <1460764917-1042-1-git-send-email-giedrius.statkevicius@gmail.com>
 <1460764917-1042-2-git-send-email-giedrius.statkevicius@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1460764917-1042-2-git-send-email-giedrius.statkevicius@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1094
Lines: 38

On Sat, Apr 16, 2016 at 03:01:57AM +0300, Giedrius Statkevičius wrote:
> Properly return rv back to the caller in the case of an error in
> parse_arg. In the process remove a unused variable 'out'.

The initial problem if I recall was value being uninitialized. Is that correct?

> 
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
> ---
>  drivers/platform/x86/asus-laptop.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index d86d42e..9a69734 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
>  			      const char *method)
>  {
>  	int rv, value;
> -	int out = 0;
>  
>  	rv = parse_arg(buf, count, &value);
> -	if (rv > 0)
> -		out = value ? 1 : 0;
> +	if (rv <= 0)
> +		return rv;
>  
>  	if (write_acpi_int(asus->handle, method, value))
>  		return -ENODEV;
> -- 
> 2.8.0
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center