Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751697AbcDUBAo (ORCPT ); Wed, 20 Apr 2016 21:00:44 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:33713 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbcDUBAl (ORCPT ); Wed, 20 Apr 2016 21:00:41 -0400 Message-ID: <57182635.5070606@gmail.com> Date: Wed, 20 Apr 2016 18:00:37 -0700 From: Frank Rowand Reply-To: frowand.list@gmail.com User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Ivan Ivanov CC: Andy Gross , David Brown , srinivas.kandagatla@linaro.org, Greg Kroah-Hartman , jslaby@suse.com, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , "devicetree@vger.kernel.org" , Linux Kernel list , "linux-arm-msm@vger.kernel.org" , linux-soc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: regression: 3a878c430fd6 ("tty: serial: msm: Add TX DMA support") drops data References: <5716BDF1.1010407@gmail.com> <5717B2CA.3020206@gmail.com> In-Reply-To: <5717B2CA.3020206@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2095 Lines: 62 On 4/20/2016 9:48 AM, Frank Rowand wrote: > On 4/19/2016 11:07 PM, Ivan Ivanov wrote: >> >>> On Apr 20, 2016, at 02:23, Frank Rowand wrote: >>> >>> Hi Ivan, >>> >>> It appears that I have found a regression caused by >>> 3a878c430fd6 ("tty: serial: msm: Add TX DMA support"). >>> >>> When I cat a file slightly larger than 126000 bytes on >>> the console, viewed via minicom connected to the serial >>> port, I am losing random chunks of data, almost always >>> three bytes in length. I have also seen a lost chunk >>> of two bytes. >>> >>> I am using the 8074 dragonboard, with the dts of >>> arch/arm/boot/dts/qcom-apq8074-dragonboard.dts. >>> The dts node is serial@f991e000, which has a >>> compatible of "qcom,msm-uartdm-v1.4", so is_uartdm >>> should be UARTDM_1P4. >> >> I don’t remember what was biggest chunk, which DMA >> could carry, sorry. Are you using DMA or just PIO? >> Is this happening only with cat and terminal or even >> when you send data in other means. I believe that >> people from Linaro could help you better. > > I assumed you would be the person who would have the > information and would be able to help maintain the > code in question since you submitted this not small > patch. Do you have a pointer to the hardware > documentation of the DMA and uart? Who at Linaro > are you suggesting? > > Thanks for the questions, I'll look into them today. I switched from cat to several variations of dd and on the host side I tried using programs other than minicom. My symptoms have now changed to something else that I have seen in the past, but I am now suspicious of my environment. I'll reset and do some more tests. I'm not sure if the driver was in DMA or PIO mode, both before the change and after. This seems like a rather important question to answer, so I'll try to verify that tonight. > > One more observation that may provide an insight: > if I cat a file multiple times, the location of > the dropped chunks varies. > > In further testing I also found examples of single > bytes lost. > > Thanks, > > Frank > >