Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751877AbcDUBMl (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 Apr 2016 21:12:41 -0400
Received: from mail-pf0-f174.google.com ([209.85.192.174]:34974 "EHLO
	mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751743AbcDUBMe (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 Apr 2016 21:12:34 -0400
Date: Wed, 20 Apr 2016 18:12:30 -0700
From: Brian Norris <briannorris@chromium.org>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: Caesar Wang <wxt@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>,
        dianders@chromium.org, smbarber@google.com,
        linux-rockchip@lists.infradead.org,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Paul Walmsley <pwalmsley@nvidia.com>, Wei Ni <wni@nvidia.com>,
        Zhang Rui <rui.zhang@intel.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 7/9] thermal: of: Add support for hardware-tracked trip
 points
Message-ID: <20160421011230.GA118377@google.com>
References: <1460950562-20652-1-git-send-email-wxt@rock-chips.com>
 <1460950562-20652-8-git-send-email-wxt@rock-chips.com>
 <20160420234818.GB2558@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160420234818.GB2558@localhost.localdomain>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1695
Lines: 43

+ Sascha

On Wed, Apr 20, 2016 at 04:48:18PM -0700, Eduardo Valentin wrote:
> On Mon, Apr 18, 2016 at 11:35:59AM +0800, Caesar Wang wrote:
> > From: Mikko Perttunen <mperttunen@nvidia.com>
> > 
> > This adds support for hardware-tracked trip points to the device tree
> <cut>
> 
> > diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> > index 97b86c5..6ef932a 100644
> > --- a/include/linux/thermal.h
> > +++ b/include/linux/thermal.h
> > @@ -335,12 +335,14 @@ struct thermal_genl_event {
> >   * @get_trend: a pointer to a function that reads the sensor temperature trend.
> >   * @set_emul_temp: a pointer to a function that sets sensor emulated
> >   *		   temperature.
> > + * @set_trips: a pointer to a function that set low/high trip temperature.
> >   */
> >  struct thermal_zone_of_device_ops {
> >  	int (*get_temp)(void *, int *);
> >  	int (*get_trend)(void *, long *);
> >  	int (*set_emul_temp)(void *, int);
> >  	int (*set_trip_temp)(void *, int, int);
> > +	int (*set_trips)(void *, int, int);
> 
> This is unfortunately a diverges from API available on thermal core. Can
> you please add first on thermal core then, use it in of thermal?
> 
> I don't want to have callbacks available only via of thermal. If we
> allow it, OF thermal becomes a separate API.

What ever happened to this effort?

http://thread.gmane.org/gmane.linux.power-management.general/59451

Patch 12 and 13 look to accomplish something similar, yet they do what
Eduardo suggested. I was testing that series at my previous job, but
unfortunately (for the fate of this series) I left that employer before
I could finish reviewing and testing it. Perhaps Caesar can resurrect
and test it?

Brian