Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751816AbcDUGpS (ORCPT ); Thu, 21 Apr 2016 02:45:18 -0400 Received: from dehamd003.servertools24.de ([31.47.254.18]:58691 "EHLO dehamd003.servertools24.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbcDUGpQ (ORCPT ); Thu, 21 Apr 2016 02:45:16 -0400 X-Greylist: delayed 384 seconds by postgrey-1.27 at vger.kernel.org; Thu, 21 Apr 2016 02:45:16 EDT Subject: Re: [alsa-devel] linux-4.6-rc4/sound/pci/ens1370.c:1551: possible bad expression ? To: David Binderman , "perex@perex.cz" , "tiwai@suse.com" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" References: From: Clemens Ladisch Message-ID: <57187578.2010609@ladisch.de> Date: Thu, 21 Apr 2016 08:38:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-PPP-Message-ID: <20160421063848.619475.15450@dehamd003.servertools24.de> X-PPP-Vhost: ladisch.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 406 Lines: 17 David Binderman wrote: > [linux-4.6-rc4/sound/pci/ens1370.c:1551]: (style) Expression '(X & 0xf0000)>= 0x4' is always false. What tool generated this message? > Source code is > > if ((ensoniq->ctrl & ES_1371_GPIO_OUTM)>= 4) > val = 1; This message is wrong; it is certainly possible for this to be true. However, there is a different bug: 4 must be ES_1371_GPIO_OUT(4). Regards, Clemens