Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751720AbcDUHYu (ORCPT ); Thu, 21 Apr 2016 03:24:50 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36559 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbcDUHYt (ORCPT ); Thu, 21 Apr 2016 03:24:49 -0400 Date: Thu, 21 Apr 2016 09:24:44 +0200 From: Daniel Vetter To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Add missing render node support Message-ID: <20160421072444.GU2510@phenom.ffwll.local> Mail-Followup-To: Eric Anholt , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1461190849-22877-1-git-send-email-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461190849-22877-1-git-send-email-eric@anholt.net> X-Operating-System: Linux phenom 4.4.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1411 Lines: 45 On Wed, Apr 20, 2016 at 03:20:49PM -0700, Eric Anholt wrote: > There shouldn't be any other driver support necessary, since none of > the driver-specific ioctls ever required auth, and none of them deal > with modesetting. Indeed, somehow I thought you need to mark them all up explicitly. But that's only the case for DRM_AUTH ioctls. Reviewed-by: Daniel Vetter Aside: I wonder whether we should go through all the drivers and replace DRM_AUTH | DRM_RENDER_ALLOW with 0? It looks a bit like drm ioctl flags are cargo culted ... -Daniel > > Signed-off-by: Eric Anholt > --- > drivers/gpu/drm/vc4/vc4_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c > index 54f9f52fa004..143dd98aa079 100644 > --- a/drivers/gpu/drm/vc4/vc4_drv.c > +++ b/drivers/gpu/drm/vc4/vc4_drv.c > @@ -81,6 +81,7 @@ static struct drm_driver vc4_drm_driver = { > DRIVER_ATOMIC | > DRIVER_GEM | > DRIVER_HAVE_IRQ | > + DRIVER_RENDER | > DRIVER_PRIME), > .lastclose = vc4_lastclose, > .irq_handler = vc4_irq, > -- > 2.8.0.rc3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch