Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752033AbcDUMBT (ORCPT ); Thu, 21 Apr 2016 08:01:19 -0400 Received: from down.free-electrons.com ([37.187.137.238]:32864 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751571AbcDUMBR (ORCPT ); Thu, 21 Apr 2016 08:01:17 -0400 Date: Thu, 21 Apr 2016 14:01:15 +0200 From: Maxime Ripard To: Stephen Boyd Cc: Mike Turquette , David Airlie , Thierry Reding , Rob Herring , Chen-Yu Tsai , Daniel Vetter , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com, Laurent Pinchart , Hans de Goede , Alexander Kaplan , Boris Brezillon , Thomas Petazzoni , Rob Clark Subject: Re: [PATCH v3 02/19] clk: sunxi: Add display and TCON0 clocks driver Message-ID: <20160421120115.GN13045@lukather> References: <1458751122-23976-1-git-send-email-maxime.ripard@free-electrons.com> <1458751122-23976-3-git-send-email-maxime.ripard@free-electrons.com> <20160415223410.GS14441@codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V7BlxAaPrdhzdIM1" Content-Disposition: inline In-Reply-To: <20160415223410.GS14441@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1762 Lines: 56 --V7BlxAaPrdhzdIM1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Stephen, On Fri, Apr 15, 2016 at 03:34:10PM -0700, Stephen Boyd wrote: > > +static int sun4i_a10_display_reset_xlate(struct reset_controller_dev *= rcdev, > > + const struct of_phandle_args *spec) > > +{ > > + /* We only have a single reset signal */ > > + return 0; > > +} >=20 > Is there a default function for this case in the reset framework? No, the reset bindings assumes that you have a cell size of 1, and it's the only case that's supported by the reset framework default xlate. I adressed the rest of your comments. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --V7BlxAaPrdhzdIM1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXGMELAAoJEBx+YmzsjxAgWPUP/R1eZAxNZm122pCMm0aVkLlf 6t8OmEZitZzon9x71hZu69phtSgeduDG824Y4OPtpwXeUUqcpBbItMZZ3DP6UoUS gbm8cLxH34BQGqjmpwRi99zk36ESqG7E1GEF07vEfWL1OWtCH7dH6O4mONzNBtyH waTLoNxjZa0DSxuB6yYpPLL5X7V6QmKHPG/kIqeDQHyzb7ynOlJyHIDCL+e/oRZ4 GBTewEgWP8utwj7yyBUh4MPISjU/yMx8A76H5uwBQs/KVDR16hHT3Sm4oHu5bphY mzelvgUnF3qHLUBA999QYfO2wMMCELVsKLViOG/8nsbvSBkiJ/XOBiKk3RhdV1g4 CFMyJ1Rht8vnzPQnOsw1aDstLpvsOtJASkRSW7m3OvnmQR6RgkBpn//urv/o1X+r rlCcWeeBS9NAHF/BWYlwSvZUg2UzSJX+g0ObuFkyX1sM3rcMMCtz+r2WfdHxHdAa Q/K9TXhwBsP+JgeMw8EnnrcBzPdNO34+OKcdhfnCDwHF6Ps3MQuJPnDSyvJEPXLr NG3rnJhLhA+u9Lj1O2Rpu7ss5/ZHvxp5JKFk2sIG68vkK+9NP3zLqeN8FraopYoA t1uJQ4tPTcCziJxGGduBASxcWmNoLJIGO0qCzMKqswrNUTc6WCIL5oTT7t2jJi5E r9wCEQZCRd8O5g+pV7Bi =Ojhx -----END PGP SIGNATURE----- --V7BlxAaPrdhzdIM1--