Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbcDUM2l (ORCPT ); Thu, 21 Apr 2016 08:28:41 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34916 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbcDUM2j (ORCPT ); Thu, 21 Apr 2016 08:28:39 -0400 From: Minfei Huang To: mingo@redhat.com, peterz@infradead.org Cc: linux-kernel@vger.kernel.org, Minfei Huang Subject: [PATCH] Remove useless test during exchanging values Date: Thu, 21 Apr 2016 20:28:28 +0800 Message-Id: <1461241708-812-1-git-send-email-mnghuan@gmail.com> X-Mailer: git-send-email 2.6.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 28 The value delta is correct as well, although calc_load_idle[idx] is equal to 0. Remove this useless test to improve performance, since this function is called more frequently. Signed-off-by: Minfei Huang --- kernel/sched/loadavg.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/sched/loadavg.c b/kernel/sched/loadavg.c index ef71590..5a5d7ae 100644 --- a/kernel/sched/loadavg.c +++ b/kernel/sched/loadavg.c @@ -216,10 +216,9 @@ void calc_load_exit_idle(void) static long calc_load_fold_idle(void) { int idx = calc_load_read_idx(); - long delta = 0; + long delta; - if (atomic_long_read(&calc_load_idle[idx])) - delta = atomic_long_xchg(&calc_load_idle[idx], 0); + delta = atomic_long_xchg(&calc_load_idle[idx], 0); return delta; } -- 2.6.3