Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752478AbcDUMqF (ORCPT ); Thu, 21 Apr 2016 08:46:05 -0400 Received: from mail.skyhub.de ([78.46.96.112]:38276 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353AbcDUMqC (ORCPT ); Thu, 21 Apr 2016 08:46:02 -0400 Date: Thu, 21 Apr 2016 14:45:42 +0200 From: Borislav Petkov To: Matt Fleming Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Elliott Subject: Re: [PATCH] x86/efi: Remove the always true EFI_DEBUG symbol Message-ID: <20160421124542.GF28821@pd.tnic> References: <1461236970-19275-1-git-send-email-matt@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1461236970-19275-1-git-send-email-matt@codeblueprint.co.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 27 On Thu, Apr 21, 2016 at 12:09:30PM +0100, Matt Fleming wrote: > This symbol is always set which makes it useless. Additionally we have > a kernel command-line switch, efi=debug, which actually controls the > printing of the memory map. > > Reported-by: Robert Elliott > Cc: Borislav Petkov > Signed-off-by: Matt Fleming > --- > arch/x86/platform/efi/efi.c | 4 ---- > 1 file changed, 4 deletions(-) Acked-by: Borislav Petkov Btw, there's also arch/ia64/kernel/efi.c:45:#define EFI_DEBUG 0 arch/ia64/kernel/efi.c:399:#if EFI_DEBUG arch/ia64/kernel/efi.c:559:#if EFI_DEBUG I'm assuming you want to put that behind "if (efi_enabled(EFI_DBG))" too... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.