Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504AbcDUMsZ (ORCPT ); Thu, 21 Apr 2016 08:48:25 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:36376 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751582AbcDUMsY (ORCPT ); Thu, 21 Apr 2016 08:48:24 -0400 Date: Thu, 21 Apr 2016 13:48:20 +0100 From: Matt Fleming To: Borislav Petkov Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Elliott Subject: Re: [PATCH] x86/efi: Remove the always true EFI_DEBUG symbol Message-ID: <20160421124820.GF2829@codeblueprint.co.uk> References: <1461236970-19275-1-git-send-email-matt@codeblueprint.co.uk> <20160421124542.GF28821@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160421124542.GF28821@pd.tnic> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 26 On Thu, 21 Apr, at 02:45:42PM, Borislav Petkov wrote: > On Thu, Apr 21, 2016 at 12:09:30PM +0100, Matt Fleming wrote: > > This symbol is always set which makes it useless. Additionally we have > > a kernel command-line switch, efi=debug, which actually controls the > > printing of the memory map. > > > > Reported-by: Robert Elliott > > Cc: Borislav Petkov > > Signed-off-by: Matt Fleming > > --- > > arch/x86/platform/efi/efi.c | 4 ---- > > 1 file changed, 4 deletions(-) > > Acked-by: Borislav Petkov > > Btw, there's also > > arch/ia64/kernel/efi.c:45:#define EFI_DEBUG 0 > arch/ia64/kernel/efi.c:399:#if EFI_DEBUG > arch/ia64/kernel/efi.c:559:#if EFI_DEBUG > > I'm assuming you want to put that behind "if (efi_enabled(EFI_DBG))" too... Hmm.. Yes, that'd be a good idea. I am in the process of setting up an Itanium box or two for runtime EFI testing, so I'll make a note of this task.