Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752517AbcDUNhR (ORCPT ); Thu, 21 Apr 2016 09:37:17 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:47294 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752134AbcDUNhP (ORCPT ); Thu, 21 Apr 2016 09:37:15 -0400 X-AuditID: cbfee68f-f79c86d0000012ad-f4-5718d7871a74 From: Jungseung Lee To: heiko.carstens@de.ibm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: RE: [PATCH] s390/compat: build error for large compat syscall args Date: Thu, 21 Apr 2016 22:37:11 +0900 Message-id: <00ee01d19bd2$e861b550$b9251ff0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AdGbz1zO9qkH1rmRSVW/1RIRnBrgKQ== Content-language: ko X-OriginalArrivalTime: 21 Apr 2016 13:37:11.0544 (UTC) FILETIME=[E86E5F80:01D19BD2] X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsWyRsSkSLf9ukS4wcJbRhaXd81hc2D0+LxJ LoAxissmJTUnsyy1SN8ugSvj7q7b7AUb2Ct6+2YzNzA+Z+1i5OSQEDCReH57BZQtJnHh3nq2 LkYuDiGBFYwSX8/8Yu5i5AAruv7cDSI+i1GiY3MjM4SzhUniz4TDTBDOMkaJywtfs4CMYhPQ krjxexPYWBGBZImHd28xg9jCAt4S29oeM4JMZRFQlWg4awoS5hWwlJi6azIThC0o8WPyPbAx zEBj1u88zgRhy0tsXvOWGeJSBYkdZ18zQozXk5h1fi4bRI2IxL4X78DiQgLKEp9P9zJC1IdK XH92CexOCYFF7BLzls8ES7AICEh8m3yIBeJLWYlNB6DmS0ocXHGDZQKjxCwkJ81CctIsJCfN QrJ6ASPLKkbR1ILkguKk9CJjveLE3OLSvHS95PzcTYzA2Dr971n/Dsa7B6wPMQpwMCrx8HLI S4QLsSaWFVfmHmI0BbpoIrOUaHI+MILzSuINjc2MLExNTI2NzC3NlMR5F0r9DBYSSE8sSc1O TS1ILYovKs1JLT7EyMTBKdXAWJmjMlcld6tKUNPt/Wp7BRs8zx8w/XDWYvLsGfb/5YRS599p mPXg4VyWD4euX9my0Ui5P1R3uvzKfNasLfvbBKdMlfc1fujCWOa6x2Nuv+TO59fM1ns8ulBU KxbK/lumcX/SjF2uCZ6NP2YkSj0Nm/1RXiyiZE9b+KyDG0QcV5Wusli5UShkkxJLcUaioRZz UXEiACrDYH2oAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrEIsWRmVeSWpSXmKPExsVy+t9jQd326xLhBs8u6Vlc3jWHzYHR4/Mm uQDGqAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zByg qUoKZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwhrGjLu7brMXbGCv6O2bzdzA +Jy1i5GDQ0LAROL6c7cuRk4gU0ziwr31bF2MXBxCArMYJTo2NzJDOFuYJP5MOMwE4SxjlLi8 8DULSAubgJbEjd+bWEFsEYFkiYd3bzGD2MIC3hLb2h4zgmxgEVCVaDhrChLmFbCUmLprMhOE LSjxY/I9sDHMQGPW7zzOBGHLS2xe85YZ4iIFiR1nXzNCjNeTmHV+LhtEjYjEvhfvwOJCAsoS n0/3MkLUh0pcf3aJaQKj0CwkK2YhWTELyYpZSEYtYGRZxSiRWpBcUJyUnmuYl1quV5yYW1ya l66XnJ+7iREcv8+kdjAe3OV+iFGAg1GJh3eDjES4EGtiWXFl7iFGCQ5mJRHelmtAId6UxMqq 1KL8+KLSnNTiQ4ymwDCYyCwlmpwPTC15JfGGxiZmRpZG5oYWRsbmSuK8j/+vCxMSSE8sSc1O TS1ILYLpY+LglGpgPC4yuXxrwfe42+9WX2a7WxG39wPb32cqwn1aMWoTWN3UHs+3Z7nhFcQ6 5fjzDCGvTczTjT42fFO952XikOvhrMwkk/L/rJ+XlPXlhpBTmxb5rFAQff5OkeuQlW1N3oKb Bwwjdtx88Glx+azAPVEW1gya3yVyQ6NFp7Jnvxd45VTSLbViD3e+EktxRqKhFnNRcSIAJLZ6 jPUCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 28 Hello, > s390/compat: build error for large compat syscall args > > Enforce 32 bit types for all compat syscall argument types. > > This way we can make sure that all arguments get correct sign > or zero extension. Otherwise incorrect code would be generated. > > E.g. for a 'long' type the COMPAT_SYSCALL_DEFINE macro wouldn't > generate code that would cause sign extension of the passed in 32 > bit user space parameter. > This can cause quite subtle bugs like e.g. the one that was fixed > with dfd948e32af2e "fs/compat: fix parameter handling for compat > readv/writev syscalls". include/linux/compat.h #ifndef __SC_DELOUSE #define __SC_DELOUSE(t,v) ((t)(unsigned long)(v)) #endif We couldn't make sure that all compat syscall arguments has 32 bit types with default definition. Is there any reason that this patch is only applied for s390? Please let me know if I miss something. BR