Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752513AbcDUNow (ORCPT ); Thu, 21 Apr 2016 09:44:52 -0400 Received: from mail.pqgruber.com ([178.189.19.235]:51196 "EHLO mail.pqgruber.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbcDUNou (ORCPT ); Thu, 21 Apr 2016 09:44:50 -0400 Date: Thu, 21 Apr 2016 15:44:45 +0200 From: Clemens Gruber To: Guenter Roeck , linux-watchdog@vger.kernel.org Cc: Wim Van Sebroeck , linux-kernel@vger.kernel.org Subject: Re: watchdog: deadlock warning with imx2_wdt driver and systemd Message-ID: <20160421134444.GA1515@archie.localdomain> References: <20160417154107.GA6762@archie.localdomain> <5718574F.5090809@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5718574F.5090809@roeck-us.net> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 662 Lines: 24 On Wed, Apr 20, 2016 at 09:30:07PM -0700, Guenter Roeck wrote: > > Hi Clemens, > > fix is to drop the call to cancel_delayed_work_sync() from watchdog_release(). > Turns out the call is not necessary. > > I'll send a proper patch in the next couple of days. > > Guenter > Hi Guenter, thank you for finding the cause of the problem! Removing the cancel_delayed_work_sync call from watchdog_release in watchdog_dev.c did fix the lockdep warning on all my boards [without having to revert commit 11d7aba9ce (watchdog: imx2: Convert to use infrastructure triggered keepalives) first]. Tested-by: Clemens Gruber Cheers, Clemens