Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752566AbcDUNqb (ORCPT ); Thu, 21 Apr 2016 09:46:31 -0400 Received: from lists.s-osg.org ([54.187.51.154]:60698 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752041AbcDUNqa (ORCPT ); Thu, 21 Apr 2016 09:46:30 -0400 Subject: Re: [PATCH 2/3] drm/exynos: Use VIDEO_SAMSUNG_EXYNOS_GSC=n as GSC Kconfig dependency References: <1459214937-18686-1-git-send-email-javier@osg.samsung.com> <1459214937-18686-3-git-send-email-javier@osg.samsung.com> Cc: linux-kernel@vger.kernel.org, Tobias Jakobi , Kukjin Kim , Seung-Woo Kim , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, Kyungmin Park , Krzysztof Kozlowski , David Airlie , Joonyoung Shim , linux-arm-kernel@lists.infradead.org To: Inki Dae From: Javier Martinez Canillas Message-ID: <5718D9A9.4040309@osg.samsung.com> Date: Thu, 21 Apr 2016 09:46:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1459214937-18686-3-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1247 Lines: 33 Hello Inki, On 03/28/2016 09:28 PM, Javier Martinez Canillas wrote: > Commit aeefb36832e5 ("drm/exynos: gsc: add device tree support and remove > usage of static mappings") made the DRM_EXYNOS_GSC Kconfig symbol to only > be selectable if the exynos-gsc V4L2 driver isn't enabled, since both use > the same HW IP block. > > But added the dependency as depends on !VIDEO_SAMSUNG_EXYNOS_GSC which is > not correct since Kconfig expressions are not boolean but tristate. So it > will only evaluate to 'n' if VIDEO_SAMSUNG_EXYNOS_GSC=y but will evaluate > to 'm' if VIDEO_SAMSUNG_S5P_G2D=m. > > This means that both the V4L2 and DRM drivers can be enabled if the former > is enabled as a module, which is not what we want. > > Signed-off-by: Javier Martinez Canillas > --- I see that only patch 1/3 from this series was picked but according to the conversation with Seung-Woo [0] in the cover letter, the GSC v4l2 and drm drivers don't support to be simultaneous enabled like is the case for FIMC. So patch 3/3 is the only one of the series that should be dropped and this one picked as well. [0]: https://lkml.org/lkml/2016/3/29/7 Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America