Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752554AbcDUNtW (ORCPT ); Thu, 21 Apr 2016 09:49:22 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:40125 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752461AbcDUNtS (ORCPT ); Thu, 21 Apr 2016 09:49:18 -0400 X-AuditID: cbfee68e-f79d96d0000012b1-0a-5718da5abf2b From: Jungseung Lee To: heiko.carstens@de.ibm.com Cc: js07.lee@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: In-reply-to: Subject: RE: [PATCH] s390/compat: build error for large compat syscall args Date: Thu, 21 Apr 2016 22:49:13 +0900 Message-id: <00ef01d19bd4$9710aec0$c5320c40$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AdGbz1zO9qkH1rmRSVW/1RIRnBrgKQABSDcA Content-language: ko X-OriginalArrivalTime: 21 Apr 2016 13:49:14.0115 (UTC) FILETIME=[971DF530:01D19BD4] X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsWyRsSkRDfqlkS4Qes9YYvLu+awOTB6fN4k F8AYxWWTkpqTWZZapG+XwJXxose0YC17RW/fbOYGxuesXYycHBICJhKLX5xlh7DFJC7cW8/W xcjFISSwglFiSv9WJpiia5uuQSWWMko8/7KdHcLZwiTx/uoeJghnGaPE07d3WUBa2AS0JG78 3gS2Q0RAVuLsnI/MIDazQIzE5CMbgUZxADVwS6xuDgIJcwrwSKz70wlWIizgLbGt7TEjiM0i oCqxfEID2EheAUuJpmn7WCFsQYkfk++xQIzUkli/8zgThC0vsXnNW2aIqxUkdpx9zQhxgpHE i3u7WSFqRCT2vXgHFhcSUJb4fLqXEaI+VOJA9yWwLyUEjrFLzH31jR3iCAGJb5MPsYDcLAH0 y6YDUPMlJQ6uuMEygVF6FpKTZiE5aRaSk2YhWb2AkWUVo2hqQXJBcVJ6kZFecWJucWleul5y fu4mRmCMnv73rG8H480D1ocYBTgYlXh4OeQlwoVYE8uKK3MPMZoCXTSRWUo0OR+YCPJK4g2N zYwsTE1MjY3MLc2UxHkTpH4GCwmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamDsEZ/wr8hwxxkb pwilte8/uV+ZHP3AdYVe65rlhxYtLDTS2nhL18f2FM+LT5+WlCv1T4ubnNN5QP523yMDrw0L A2dffBwz5aND/fb5y3MvKO/8Lrl5v2C/tF7Qi+Ktt2PsvITOMHFtuxVvwc9p8vzuzu3Nu28L bfVsi+8SvbTt6s634at9OyLTlFiKMxINtZiLihMBQbbcC8wCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjleLIzCtJLcpLzFFi42I5/e+xgG7ULYlwg2mTeC0u75rD5sDo8XmT XABjVAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7Q VCWFssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6viFBcD1GBmggYQ1jxose04K17BW9fbOZGxif s3YxcnJICJhIXNt0jQ3CFpO4cG89kM3FISSwlFHi+Zft7BDOFiaJ91f3MEE4yxglnr69ywLS wiagJXHj9yawUSICshJn53xkBrGZBWIkJh/ZCDSKA6iBW2J1cxBImFOAR2Ldn06wEmEBb4lt bY8ZQWwWAVWJ5RMawEbyClhKNE3bxwphC0r8mHyPBWKklsT6nceZIGx5ic1r3jJDXK0gsePs a0aIE4wkXtzbzQpRIyKx78U7sLiQgLLE59O9jBD1oRIHui+xTWAUnYVkxSwkK2YhWTELyagF jCyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYLTwDPpHYyHd7kfYhTgYFTi4d0gIxEu xJpYVlyZe4hRgoNZSYS35RpQiDclsbIqtSg/vqg0J7X4EKMpMBAmMkuJJucDU1ReSbyhsYmZ kaWRuaGFkbG5kjjv4//rwoQE0hNLUrNTUwtSi2D6mDg4pRoYl+s8WXRh6/v2Xamcnk6W1vN8 96dMl9Wf8iBzx5FPLb+UX0Z99j913ev7wnVrAg2Tu+9t7cj9ZS2yZ3peO9MMn1jpe+7rhHbb 3GZuyjn/aPttDhG27XcWzeU5f34zh9/O5CfsbKev7Zp74GBPr+OvWYvFu1Z85Jqw+XSI2pqf TpMcU67tfiq4ZIISS3FGoqEWc1FxIgCBk8W+GQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 27 Hello, > s390/compat: build error for large compat syscall args > > Enforce 32 bit types for all compat syscall argument types. > > This way we can make sure that all arguments get correct sign > or zero extension. Otherwise incorrect code would be generated. > > E.g. for a 'long' type the COMPAT_SYSCALL_DEFINE macro wouldn't > generate code that would cause sign extension of the passed in 32 > bit user space parameter. > This can cause quite subtle bugs like e.g. the one that was fixed > with dfd948e32af2e "fs/compat: fix parameter handling for compat > readv/writev syscalls". include/linux/compat.h #ifndef __SC_DELOUSE #define __SC_DELOUSE(t,v) ((t)(unsigned long)(v)) #endif We couldn't make sure that all compat syscall arguments has 32 bit types with default definition. Is there any reason that this patch is only applied for s390? Please let me know if I miss something. BR