Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752957AbcDUPHH (ORCPT ); Thu, 21 Apr 2016 11:07:07 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60072 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752134AbcDUPHF (ORCPT ); Thu, 21 Apr 2016 11:07:05 -0400 Date: Thu, 21 Apr 2016 16:06:56 +0100 From: Mark Brown To: Richard Fitzgerald Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Message-ID: <20160421150656.GP3217@sirena.org.uk> References: <1461242174-11310-1-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zQiiCAM5ptAyb9EE" Content-Disposition: inline In-Reply-To: <1461242174-11310-1-git-send-email-rf@opensource.wolfsonmicro.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2] regulator: core: Add debugfs to show constraint flags X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1271 Lines: 38 --zQiiCAM5ptAyb9EE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 21, 2016 at 01:36:14PM +0100, Richard Fitzgerald wrote: > + ret = snprintf(buf, PAGE_SIZE, > + "always_on: %u\nboot_on: %u\napply_uV: %u\nramp_disable: %u\n" > + "soft_start: %u\npull_down: %u\nover_current_protection: %u\n", > + !!c->always_on, > + !!c->boot_on, > + !!c->apply_uV, > + !!c->ramp_disable, > + !!c->soft_start, > + !!c->pull_down, > + !!c->over_current_protection); Can we try for legibility please? Trying to cram everything onto the minimum number of lines really doesn't help and the !!s either do nothing or will end up obscuring information down the line. --zQiiCAM5ptAyb9EE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXGOyPAAoJECTWi3JdVIfQQ1YIAIIiNdPm8Cn6vWsSzQyOussC DrrsbexjYWi18zGqErA4v28JIb/ztPwMJ93CWiuwpm2u1h2ugYJAlOF67+YidEC8 HW3A+XJTx+wY8M3jyGQC6vO9wBcKS+ufDMFkzAaTZledM/gCObwGK5nnUUQ8mKLx iJgcbLWupaLXdM0ucPZ6kVIksAACi5vBvoL5lJvO/fZZkdpbxq9kiBSHvb6ujgxN EBc7bMz5TDI2cfsJYRkzr9EuXdB6VHslcEChDPQ5DFXk/Uo59+v32n4ZxSBx4NW2 b90mIEBqtxzW7f8TNcya/qEfMGAD4VLzfVM+K2PIDRelRmJVd8t5soKWxDnA/x8= =mlwA -----END PGP SIGNATURE----- --zQiiCAM5ptAyb9EE--