Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752680AbcDUPZD (ORCPT ); Thu, 21 Apr 2016 11:25:03 -0400 Received: from mail.kernel.org ([198.145.29.136]:42201 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071AbcDUPZA (ORCPT ); Thu, 21 Apr 2016 11:25:00 -0400 Date: Thu, 21 Apr 2016 10:24:56 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Herbert Xu , "David S. Miller" , Vladimir Zapolskiy , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt handler Message-ID: <20160421152456.GA8087@rob-hp-laptop> References: <1461073452-10426-1-git-send-email-k.kozlowski@samsung.com> <1461073452-10426-2-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461073452-10426-2-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 614 Lines: 13 On Tue, Apr 19, 2016 at 03:44:12PM +0200, Krzysztof Kozlowski wrote: > Beside regular feed control interrupt, the driver requires also hash > interrupt for older SoCs (samsung,s5pv210-secss). However after > requesting it, the interrupt handler isn't doing anything with it, not > even clearing the hash interrupt bit. > > Driver does not provide hash functions so it is safe to remove the hash > interrupt related code and to not require the interrupt in Device Tree. NAK for the DT change. If the h/w has a 2nd interrupt, then it should be defined. Whether the driver uses it or not is a driver problem. Rob