Message-ID: <1461258007.1918.12.camel@perches.com>
Subject: Re: [PATCH 3/3] checkpatch: relax Kconfig help text line number
 threshold
From: Joe Perches <joe@perches.com>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>,
        Andy Whitcroft <apw@canonical.com>, Andi Kleen <ak@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com
Date: Thu, 21 Apr 2016 10:00:07 -0700
In-Reply-To: <1461245285-14918-3-git-send-email-yingjoe.chen@mediatek.com>
References: <1461245285-14918-1-git-send-email-yingjoe.chen@mediatek.com>
	 <1461245285-14918-3-git-send-email-yingjoe.chen@mediatek.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1228
Lines: 34

On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote:
> Current threshold is too strict and many upstream patch doesn't pass
> this test. Relax it.

I don't have an issue with this.
Maybe Andi Kleen does though.

> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
> 
> ---
> In v4.6-rc1, 171 new config options was added, and 87 of those options
> have < 4 lines and 24 options have only 1 line. After this change,
> checkpatch only raise warning when help text only contain 1 line.
> 
> Some options try to workaround this check by adding 2 lines
> template like 'If you have this device...' which doesn't add value.
> 
> ---
> ?scripts/checkpatch.pl | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2bf4499..33b9bfc 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -47,7 +47,7 @@ my $configuration_file = ".checkpatch.conf";
> ?my $max_line_length = 80;
> ?my $ignore_perl_version = 0;
> ?my $minimum_perl_version = 5.10.0;
> -my $min_conf_desc_length = 4;
> +my $min_conf_desc_length = 2;
> ?my $spelling_file = "$D/spelling.txt";
> ?my $codespell = 0;
> ?my $codespellfile = "/usr/share/codespell/dictionary.txt";