Message-ID: <1461258823.6620.322.camel@linux.intel.com>
Subject: Re: [PATCH 5/6] fs: define a string representation of the
 kernel_read_file_id enumeration
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kees Cook <keescook@chromium.org>
Cc: James Morris <jmorris@namei.org>, Mimi Zohar <zohar@linux.vnet.ibm.com>,
        Joe Perches <joe@perches.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Serge E. Hallyn" <serge@hallyn.com>, Jonathan Corbet <corbet@lwn.net>,
        Kalle Valo <kvalo@codeaurora.org>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        Guenter Roeck <linux@roeck-us.net>, Jiri Slaby <jslaby@suse.com>,
        Paul Moore <pmoore@redhat.com>, Stephen Smalley <sds@tycho.nsa.gov>,
        Casey Schaufler <casey@schaufler-ca.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        linux-security-module <linux-security-module@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Date: Thu, 21 Apr 2016 20:13:43 +0300
In-Reply-To: <CAGXu5jJ33XUJ+8hvWPg4sKJ6ajqkXU5FeCsuQWuNohvpEHhWWA@mail.gmail.com>
References: <1461192388-13900-1-git-send-email-keescook@chromium.org>
	 <1461192388-13900-6-git-send-email-keescook@chromium.org>
	 <1461245188.6620.316.camel@linux.intel.com>
	 <CAGXu5jJ33XUJ+8hvWPg4sKJ6ajqkXU5FeCsuQWuNohvpEHhWWA@mail.gmail.com>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1930
Lines: 51

On Thu, 2016-04-21 at 09:47 -0700, Kees Cook wrote:
> On Thu, Apr 21, 2016 at 6:26 AM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > 
> > On Wed, 2016-04-20 at 15:46 -0700, Kees Cook wrote:
> > > 
> > > From: Mimi Zohar <zohar@linux.vnet.ibm.com>
> > > 
> > > A string representation of the kernel_read_file_id enumeration is
> > > needed for displaying messages (eg. pr_info, auditing) that can be
> > > used by multiple LSMs and the integrity subsystem.  To simplify
> > > keeping the list of strings up to date with the enumeration, this
> > > patch defines two new preprocessing macros named __fid_enumify and
> > > __fid_stringify to create the enumeration and an array of strings.
> > > kernel_read_file_id_str() returns a string based on the
> > > enumeration.


> > I got this
> > 
> > In file included from /home/andy/prj/linux-
> > topic/include/linux/seq_file.h:10:0,
> >                  from /home/andy/prj/linux-
> > topic/include/linux/pinctrl/consumer.h:17,
> >                  from /home/andy/prj/linux-
> > topic/include/linux/pinctrl/devinfo.h:21,
> >                  from /home/andy/prj/linux-
> > topic/include/linux/device.h:24,
> >                  from /home/andy/prj/linux-
> > topic/include/linux/dmaengine.h:20,
> >                  from /home/andy/prj/linux-
> > topic/drivers/dma/dw/core.c:15:
> > /home/andy/prj/linux-topic/include/linux/fs.h:2627:74: warning: type
> > qualifiers ignored on function return type [-Wignored-qualifiers]
> >  static inline const char * const kernel_read_file_id_str(enum
> > kernel_read_file_id id)
> What gcc version are you using? Seems like I need to drop the added
> "const" on the return?


$ gcc --version
gcc (Debian 5.3.1-14) 5.3.1 20160409


Build was done with 
$ make W=1


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy