Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752782AbcDURQ4 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 Apr 2016 13:16:56 -0400
Received: from smtprelay0094.hostedemail.com ([216.40.44.94]:43299 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751931AbcDURQz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 Apr 2016 13:16:55 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:960:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:4321:5007:7904:10004:10400:10848:11232:11658:11783:11914:12043:12517:12519:12740:13069:13311:13357:13439:13894:14181:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:8,LUA_SUMMARY:none
X-HE-Tag: shame29_1e9fb2e5383b
X-Filterd-Recvd-Size: 1556
Message-ID: <1461259011.1918.23.camel@perches.com>
Subject: Re: [PATCH 1/3] checkpatch: add Kconfig 'default n' test
From: Joe Perches <joe@perches.com>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>,
        Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com
Date: Thu, 21 Apr 2016 10:16:51 -0700
In-Reply-To: <1461245285-14918-1-git-send-email-yingjoe.chen@mediatek.com>
References: <1461245285-14918-1-git-send-email-yingjoe.chen@mediatek.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.2-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 705
Lines: 25

On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote:
> If a Kconfig config option doesn't specify 'default', the default
> will be n. Adding 'default n' is unnecessary.
> 
> Add a test to warn about this.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2600,6 +2600,13 @@ sub process {
> ?			?????"Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
> ?		}
> ?
> +# discourage the use of default n
> +		if ($realfile =~ /Kconfig/ &&
> +		????$line =~ /^\+\s*\bdefault\b\s*n\s*$/) {

maybe line =~ /^\+\s*default\s+n/i

Also, there are some oddities like:

arch/mips/cavium-octeon/Kconfig:????????default "n"

and a dozen or so uses like

	default n if <foo>