Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520AbcDURuA (ORCPT ); Thu, 21 Apr 2016 13:50:00 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54009 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752435AbcDURt6 (ORCPT ); Thu, 21 Apr 2016 13:49:58 -0400 Date: Thu, 21 Apr 2016 13:49:55 -0400 (EDT) Message-Id: <20160421.134955.768804097889808245.davem@davemloft.net> To: ast@fb.com Cc: rostedt@goodmis.org, peterz@infradead.org, mingo@kernel.org, daniel@iogearbox.net, acme@infradead.org, wangnan0@huawei.com, jbacik@fb.com, brendan.d.gregg@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH net-next] perf, bpf: minimize the size of perf_trace_() tracepoint handler From: David Miller In-Reply-To: <1461035510-2810305-1-git-send-email-ast@fb.com> References: <1461035510-2810305-1-git-send-email-ast@fb.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Apr 2016 10:49:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 811 Lines: 22 From: Alexei Starovoitov Date: Mon, 18 Apr 2016 20:11:50 -0700 > move trace_call_bpf() into helper function to minimize the size > of perf_trace_*() tracepoint handlers. > text data bss dec hex filename > 10541679 5526646 2945024 19013349 1221ee5 vmlinux_before > 10509422 5526646 2945024 18981092 121a0e4 vmlinux_after > > It may seem that perf_fetch_caller_regs() can also be moved, > but that is incorrect, since ip/sp will be wrong. > > bpf+tracepoint performance is not affected, since > perf_swevent_put_recursion_context() is now inlined. > export_symbol_gpl can also be dropped. > > No measurable change in normal perf tracepoints. > > Suggested-by: Steven Rostedt > Signed-off-by: Alexei Starovoitov Applied, thanks Alexei.