Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752969AbcDUU7N (ORCPT ); Thu, 21 Apr 2016 16:59:13 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:49188 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbcDUU7L (ORCPT ); Thu, 21 Apr 2016 16:59:11 -0400 Date: Thu, 21 Apr 2016 13:59:09 -0700 From: Darren Hart To: Andy Shevchenko Cc: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= , Corentin Chary , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Message-ID: <20160421205909.GA56887@f23x64.localdomain> References: <1460764917-1042-1-git-send-email-giedrius.statkevicius@gmail.com> <1460764917-1042-2-git-send-email-giedrius.statkevicius@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1213 Lines: 33 On Thu, Apr 21, 2016 at 11:34:13PM +0300, Andy Shevchenko wrote: > On Sat, Apr 16, 2016 at 3:01 AM, Giedrius Statkevičius > wrote: > > Properly return rv back to the caller in the case of an error in > > parse_arg. In the process remove a unused variable 'out'. > > > > Signed-off-by: Giedrius Statkevičius > > --- > > drivers/platform/x86/asus-laptop.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c > > index d86d42e..9a69734 100644 > > --- a/drivers/platform/x86/asus-laptop.c > > +++ b/drivers/platform/x86/asus-laptop.c > > @@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus, > > const char *method) > > { > > int rv, value; > > - int out = 0; > > > > rv = parse_arg(buf, count, &value); > > Just noticed (might be a separate patch for this) that parse_arg > pretty much duplicated kstrotint(). Ah, thanks Andy. I'd like to take this one as is, but a cleanup for that would be welcome indeed. -- Darren Hart Intel Open Source Technology Center