Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752182AbcDUVlM (ORCPT ); Thu, 21 Apr 2016 17:41:12 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36626 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbcDUVlJ (ORCPT ); Thu, 21 Apr 2016 17:41:09 -0400 MIME-Version: 1.0 In-Reply-To: References: <1461105548-20618-1-git-send-email-octavian.purdila@intel.com> <1461105548-20618-6-git-send-email-octavian.purdila@intel.com> Date: Fri, 22 Apr 2016 00:41:07 +0300 Message-ID: Subject: Re: [RFC PATCH v2 05/10] i2c: add support for ACPI reconfigure notifications From: Octavian Purdila To: Andy Shevchenko Cc: "Rafael J. Wysocki" , Len Brown , Matt Fleming , Mark Brown , Wolfram Sang , Joel Becker , "linux-acpi@vger.kernel.org" , linux-efi@vger.kernel.org, linux-i2c , linux-spi , "linux-kernel@vger.kernel.org" , Irina Tirdea Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1711 Lines: 63 On Fri, Apr 22, 2016 at 12:27 AM, Andy Shevchenko wrote: > Hi Andy and thanks for the review! > On Wed, Apr 20, 2016 at 1:39 AM, Octavian Purdila > wrote: > > This patch adds supports for I2C device enumeration and removal via > > ACPI reconfiguration notifications that are send as a result of an > > ACPI table load or unload operation. > > > > > acpi_dev_free_resource_list(&resource_list); > > > > + strlcpy(info->type, dev_name(&adev->dev), sizeof(info->type)); > > strscpy() ? That is the original code, I just moved it in a different function. Its probably best if we use a separate patch for this, but is it worth it? > > > +static int acpi_i2c_match_adapter(struct device *dev, void *data) > > +{ > > + struct i2c_adapter *adapter = i2c_verify_adapter(dev); > > + > > + if (!adapter) > > + return 0; > > + > > > + return ACPI_HANDLE(dev) == (acpi_handle)data; > > What is suppose to return? Hidden bool to integer conversion is not > best option I suppose. > per bus_find_device() : * The callback should return 0 if the device doesn't match and non-zero * if it does. If the callback returns non-zero, this function will * return to the caller and not iterate over any more devices. */ struct device *bus_find_device(struct bus_type *bus, struct device *start, void *data, int (*match)(struct device *dev, void *data)) > > +} > > + > > +static int acpi_i2c_match_device(struct device *dev, void *data) > > +{ > > + return ACPI_COMPANION(dev) == data; > > Ditto. > > > +} > > -- > With Best Regards, > Andy Shevchenko