Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752473AbcDUVsd (ORCPT ); Thu, 21 Apr 2016 17:48:33 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:35105 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697AbcDUVsa (ORCPT ); Thu, 21 Apr 2016 17:48:30 -0400 Date: Thu, 21 Apr 2016 14:48:26 -0700 From: Brian Norris To: Jianqun Xu Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, catalin.marinas@arm.com, will.deacon@arm.com, heiko@sntech.de, huangtao@rock-chips.com, davidriley@chromium.org, dianders@chromium.org, jwerner@chromium.org, smbarber@chromium.org, devicetree@vger.kernel.org, rockchip-discuss@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for rk3399 SoCs Message-ID: <20160421214826.GA69116@google.com> References: <1461122150-9042-1-git-send-email-jay.xu@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461122150-9042-1-git-send-email-jay.xu@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1021 Lines: 36 Hi, On Wed, Apr 20, 2016 at 11:15:50AM +0800, Jianqun Xu wrote: > This patch adds core dtsi file for rk3399 found on Rockchip > rk3399 SoCs, tested on rk3399 evb. > > Signed-off-by: Jianqun Xu > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1744 ++++++++++++++++++++++++++++++ > 1 file changed, 1744 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3399.dtsi > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > new file mode 100644 > index 0000000..fa6fc2c > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -0,0 +1,1744 @@ [...] > + emmc_phy: phy { > + compatible = "rockchip,rk3399-emmc-phy"; > + reg-offset = <0xf780>; This property is not documented. The current doc says we "require" reg, but you're kinda misusing it, I believe. At any rate, the current phy driver won't probe without 'reg'. > + #phy-cells = <0>; > + rockchip,grf = <&grf>; > + status = "disabled"; > + }; [...] Brian