Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752027AbcDUXno (ORCPT ); Thu, 21 Apr 2016 19:43:44 -0400 Received: from g9t5009.houston.hp.com ([15.240.92.67]:42777 "EHLO g9t5009.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbcDUXnn (ORCPT ); Thu, 21 Apr 2016 19:43:43 -0400 Subject: Re: [PATCH v3 0/2] Align mmap address for DAX pmd mappings To: Mike Kravetz , Matthew Wilcox References: <1460652511-19636-1-git-send-email-toshi.kani@hpe.com> <20160415220531.c7b55adb5b26eb749fae3186@linux-foundation.org> <20160418202610.GA17889@quack2.suse.cz> <20160419182347.GA29068@linux.intel.com> <571844A1.5080703@hpe.com> <20160421070625.GB29068@linux.intel.com> <57193658.9020803@oracle.com> Cc: Jan Kara , "linux-nvdimm@ml01.01.org" , "david@fromorbit.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "adilger.kernel@dilger.ca" , "viro@zeniv.linux.org.uk" , "linux-fsdevel@vger.kernel.org" , "tytso@mit.edu" , Andrew Morton , "kirill.shutemov@linux.intel.com" From: Toshi Kani Message-ID: <571965AB.9070707@hpe.com> Date: Thu, 21 Apr 2016 19:43:39 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <57193658.9020803@oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 20 On 4/21/2016 4:21 PM, Mike Kravetz wrote: > On 04/21/2016 12:06 AM, Matthew Wilcox wrote: >> On Wed, Apr 20, 2016 at 11:10:25PM -0400, Toshi Kani wrote: >>> How about moving the function (as is) to mm/huge_memory.c, rename it to >>> get_hugepage_unmapped_area(), which is defined to NULL in huge_mm.h >>> when TRANSPARENT_HUGEPAGE is unset? >> Great idea. Perhaps it should look something like this? >> >> unsigned long thp_get_unmapped_area(struct file *filp, unsigned long addr, >> unsigned long len, unsigned long pgoff, unsigned long flags) >> { > Might want to keep the future possibility of PUD_SIZE THP in mind? Yes, this is why the func name does not say 'pmd'. It can be extended to support PUD_SIZE in future. Thanks, -Toshi