Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752149AbcDVByk (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 Apr 2016 21:54:40 -0400
Received: from mail-pf0-f193.google.com ([209.85.192.193]:33021 "EHLO
	mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751583AbcDVByi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 Apr 2016 21:54:38 -0400
Subject: Re: [PATCH 7/9] thermal: of: Add support for hardware-tracked trip
 points
To: Brian Norris <briannorris@chromium.org>,
        Eduardo Valentin <edubezval@gmail.com>,
        Sascha Hauer <kernel@pengutronix.de>
References: <1460950562-20652-1-git-send-email-wxt@rock-chips.com>
 <1460950562-20652-8-git-send-email-wxt@rock-chips.com>
 <20160420234818.GB2558@localhost.localdomain>
 <20160421011230.GA118377@google.com>
Cc: Wei Ni <wni@nvidia.com>, Heiko Stuebner <heiko@sntech.de>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        dianders@chromium.org, Mikko Perttunen <mperttunen@nvidia.com>,
        linux-rockchip@lists.infradead.org, smbarber@google.com,
        Paul Walmsley <pwalmsley@nvidia.com>, Zhang Rui <rui.zhang@intel.com>,
        Caesar Wang <wxt@rock-chips.com>, eddie.cai@rock-chips.com,
        huangtao@rock-chips.com
From: Caesar Wang <caesar.upstream@gmail.com>
Message-ID: <5719844B.3040703@gmail.com>
Date: Fri, 22 Apr 2016 09:54:19 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <20160421011230.GA118377@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2881
Lines: 78

Hi Brian, Eduardo, Sascha

在 2016年04月21日 09:12, Brian Norris 写道:
> + Sascha
>
> On Wed, Apr 20, 2016 at 04:48:18PM -0700, Eduardo Valentin wrote:
>> On Mon, Apr 18, 2016 at 11:35:59AM +0800, Caesar Wang wrote:
>>> From: Mikko Perttunen <mperttunen@nvidia.com>
>>>
>>> This adds support for hardware-tracked trip points to the device tree
>> <cut>
>>
>>> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
>>> index 97b86c5..6ef932a 100644
>>> --- a/include/linux/thermal.h
>>> +++ b/include/linux/thermal.h
>>> @@ -335,12 +335,14 @@ struct thermal_genl_event {
>>>    * @get_trend: a pointer to a function that reads the sensor temperature trend.
>>>    * @set_emul_temp: a pointer to a function that sets sensor emulated
>>>    *		   temperature.
>>> + * @set_trips: a pointer to a function that set low/high trip temperature.
>>>    */
>>>   struct thermal_zone_of_device_ops {
>>>   	int (*get_temp)(void *, int *);
>>>   	int (*get_trend)(void *, long *);
>>>   	int (*set_emul_temp)(void *, int);
>>>   	int (*set_trip_temp)(void *, int, int);
>>> +	int (*set_trips)(void *, int, int);
>> This is unfortunately a diverges from API available on thermal core. Can
>> you please add first on thermal core then, use it in of thermal?
>>
>> I don't want to have callbacks available only via of thermal. If we
>> allow it, OF thermal becomes a separate API.
> What ever happened to this effort?
>
> http://thread.gmane.org/gmane.linux.power-management.general/59451
>
> Patch 12 and 13 look to accomplish something similar, yet they do what
> Eduardo suggested. I was testing that series at my previous job, but
> unfortunately (for the fate of this series) I left that employer before
> I could finish reviewing and testing it. Perhaps Caesar can resurrect
> and test it?

@Brian
Yes, I can

Sure, I can.

I see the Sascha's newest thermal patches in patchwork.
The following patches are still needed, right?

6446191 New          [06/16] thermal: inline only once used function
6446111 New          [07/16] thermal: streamline get_trend callbacks
6445871 New          [08/16] thermal: Allow sensor ops to fail with -ENOSYS
6445861 New          [09/16] thermal: of: always set sensor related 
callbacks
6446221 New          [10/16] thermal: Make struct 
thermal_zone_device_ops const
6446201 New          [11/16] thermal: bang-bang governor: act on lower 
trip boundary
6445891 New          [12/16] thermal: thermal: Add support for 
hardware-tracked trip points
6445911 New          [13/16] thermal: of: implement .set_trips for 
device tree thermal zones

@Sascha, Eduardo
Can you share your discussion content for the above patches as remembered?

Thanks,

-Caesar

> Brian
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip