Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752795AbcDVG4H (ORCPT ); Fri, 22 Apr 2016 02:56:07 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:40785 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662AbcDVG4D (ORCPT ); Fri, 22 Apr 2016 02:56:03 -0400 Subject: Re: [PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes To: "David Rivshin (Allworx)" , , References: <1461261035-5578-1-git-send-email-drivshin.allworx@gmail.com> CC: , , , David Miller , Grygorii Strashko , Andrew Goodbody , Markus Brunner , Nicolas Chauvet From: Mugunthan V N Message-ID: <5719CAE1.40801@ti.com> Date: Fri, 22 Apr 2016 12:25:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1461261035-5578-1-git-send-email-drivshin.allworx@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1097 Lines: 31 On Thursday 21 April 2016 11:20 PM, David Rivshin (Allworx) wrote: > From: David Rivshin > > The first patch fixes a bug that makes dual_emac mode break if > either slave uses the phy-handle property in the devicetree. > > The second patch fixes some cosmetic problems with error messages, > and also makes the binding documentation more explicit. > > The third patch cleans up the fixed-link case to work like > the now-fixed phy-handle case. > > I have tested on the following hardware configurations: > - (EVMSK) dual emac, phy_id property in both slaves > - (EVMSK) dual emac, phy-handle property in both slaves > - (BeagleBoneBlack) single emac, phy_id property > - (custom) single emac, fixed-link subnode > > Nicolas Chauvet reported testing on an HP t410 (dm8148). > > Markus Brunner reported testing v1 on the following [1]: > - emac0 with phy_id and emac1 with fixed phy > - emac0 with phy-handle and emac1 with fixed phy > - emac0 with fixed phy and emac1 with fixed phy > > Reviewed-by: Mugunthan V N Regards Mugunthan V N