Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753996AbcDVJCV (ORCPT ); Fri, 22 Apr 2016 05:02:21 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:12630 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753537AbcDVJCT (ORCPT ); Fri, 22 Apr 2016 05:02:19 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 22 Apr 2016 02:02:07 -0700 Message-ID: <5719E5DC.8040305@nvidia.com> Date: Fri, 22 Apr 2016 14:20:36 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: "Kim, Milo" , CC: , , , , , , Subject: Re: [PATCH 2/7] mfd: lp8788: Use devm_mfd_add_devices and devm_regmap_add_irq_chip References: <1461241558-26983-1-git-send-email-ldewangan@nvidia.com> <1461241558-26983-3-git-send-email-ldewangan@nvidia.com> <57195F1A.7070506@ti.com> In-Reply-To: <57195F1A.7070506@ti.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRHKMAIL102.nvidia.com (10.25.59.16) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 590 Lines: 16 On Friday 22 April 2016 04:45 AM, Kim, Milo wrote: > Hi Laxman, > > On 4/21/2016 9:25 PM, Laxman Dewangan wrote: >> Use devm_mfd_add_devices() for adding MFD child devices and >> devm_regmap_add_irq_chip() for IRQ chip registration. > > This patch doesn't include the code regarding devm_mfd_add_devices(). > Could you check it again? Or am I missing any previous patches? Sigh.. yaah, it is missed. Dont know how I missed it in my grep result. I will recycle the patch. But I like to get review other patches also for V2. External code review is more stronger then self code review.