Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754081AbcDVJDg (ORCPT ); Fri, 22 Apr 2016 05:03:36 -0400 Received: from mail.tricorecenter.de ([217.6.246.34]:44793 "EHLO root.phytec.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753656AbcDVJDd (ORCPT ); Fri, 22 Apr 2016 05:03:33 -0400 Subject: Re: [PATCH v2 3/7] regulator: rk808: Migrate to regulator core's simplified DT parsing code To: Mark Brown References: <1461244361-45686-1-git-send-email-w.egorov@phytec.de> <1461244361-45686-4-git-send-email-w.egorov@phytec.de> <20160421160120.GT3217@sirena.org.uk> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, mturquette@baylibre.com, sboyd@codeaurora.org, lee.jones@linaro.org, lgirdwood@gmail.com, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, dianders@chromium.org, zyw@rock-chips.com From: Wadim Egorov Message-ID: <5719E8CD.1070304@phytec.de> Date: Fri, 22 Apr 2016 11:03:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160421160120.GT3217@sirena.org.uk> X-MIMETrack: Itemize by SMTP Server on Idefix/Phytec(Release 9.0.1FP5 HF413|March 21, 2016) at 22.04.2016 11:03:09, Serialize by Router on Idefix/Phytec(Release 9.0.1FP5 HF413|March 21, 2016) at 22.04.2016 11:03:09, Serialize complete at 22.04.2016 11:03:09 X-TNEFEvaluated: 1 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=windows-1252 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1083 Lines: 30 On 21.04.2016 18:01, Mark Brown wrote: > On Thu, Apr 21, 2016 at 03:12:37PM +0200, Wadim Egorov wrote: > >> +static int rk808_set_suspend_voltage(struct regulator_dev *rdev, int uv) >> +{ >> + unsigned int reg; >> + int sel = regulator_map_voltage_linear(rdev, uv, uv); >> + >> + if (sel < 0) >> + return -EINVAL; >> + >> + reg = rdev->desc->vsel_reg + RK808_SLP_REG_OFFSET; >> + >> + return regmap_update_bits(rdev->regmap, reg, >> + rdev->desc->vsel_mask, >> + sel); >> +} > This is fine but is adding a new feature and not part of the refactoring > that the changelog talked about so should be in a separate commit. This is not really a new feature. rk808_set_suspend_voltage() was using regulator_map_voltage_linear_range(). I have just renamed the function to rk808_set_suspend_voltage_range() and added an ops struct for ranges. Yes, I have also added rk808_set_suspend_voltage(), but this is just a split for the two types of ops that the driver needs now. This was needed, because the driver used only linear ranges. IMO it should be a part of the refactoring.