Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754067AbcDVJMD (ORCPT ); Fri, 22 Apr 2016 05:12:03 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:36178 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753547AbcDVJL6 (ORCPT ); Fri, 22 Apr 2016 05:11:58 -0400 Subject: Re: [PATCH v2 05/13] ARM: dts: db600c: add pmic regulator supplies To: Stephen Boyd , Andy Gross , linux-arm-msm@vger.kernel.org References: <1460453642-5809-1-git-send-email-srinivas.kandagatla@linaro.org> <1460453642-5809-6-git-send-email-srinivas.kandagatla@linaro.org> <571682A1.9010000@codeaurora.org> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org From: Srinivas Kandagatla Message-ID: <5719EADB.9090704@linaro.org> Date: Fri, 22 Apr 2016 10:11:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <571682A1.9010000@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1613 Lines: 50 On 19/04/16 20:10, Stephen Boyd wrote: > On 04/12/2016 02:33 AM, Srinivas Kandagatla wrote: >> This patch adds pmic regulator supplies connected on the board. >> Rest of the invidual regulators would be added as and when required by >> the devices. >> >> Signed-off-by: Srinivas Kandagatla >> Acked-by: Bjorn Andersson >> --- >> arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts | 62 +++++++++++++++++++++++++ >> 1 file changed, 62 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts b/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts >> index 57d4500..6695b00 100644 >> --- a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts >> +++ b/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts >> @@ -9,7 +9,69 @@ >> serial1 = &gsbi1_serial; >> }; >> >> + regulators { >> + compatible = "simple-bus"; >> + vph: regulator-fixed@1 { >> + compatible = "regulator-fixed"; >> + regulator-min-microvolt = <4500000>; >> + regulator-max-microvolt = <4500000>; >> + regulator-name = "VPH"; >> + regulator-type = "voltage"; >> + regulator-boot-on; >> + }; >> + }; > > Just curious why we added the vph supply? Is that for some framework > requirement? We haven't done this on other boards, although we probably > should if there's a good reason for it. This is an on board 12V TO 4.5V @5.5A DC/DC convertor for PMIC VPH power. Yep we should do something similar on the other boards too. Without this probably you would notice some error messages from rpm_regulators about missing supply nodes. thanks, srini >