Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753404AbcDVKFY (ORCPT ); Fri, 22 Apr 2016 06:05:24 -0400 Received: from exsmtp02.microchip.com ([198.175.253.38]:40744 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751084AbcDVKFU (ORCPT ); Fri, 22 Apr 2016 06:05:20 -0400 X-Greylist: delayed 317 seconds by postgrey-1.27 at vger.kernel.org; Fri, 22 Apr 2016 06:05:20 EDT Subject: Re: [patch] spi: pic32-sqi: silence array overflow warning To: Dan Carpenter References: <20160422095524.GB11398@mwanda> CC: Mark Brown , , , From: Purna Chandra Mandal Message-ID: <5719F5B5.2030101@microchip.com> Date: Fri, 22 Apr 2016 15:28:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160422095524.GB11398@mwanda> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 24 On 04/22/2016 03:25 PM, Dan Carpenter wrote: > We read one element beyond the end of the array when we access > "rdesc[i + 1]" so it causes a static checker warning. It's harmless > because we write over it again on the next line. But let's just silence > the warning. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/spi/spi-pic32-sqi.c b/drivers/spi/spi-pic32-sqi.c > index b215347..74b9e68 100644 > --- a/drivers/spi/spi-pic32-sqi.c > +++ b/drivers/spi/spi-pic32-sqi.c > @@ -537,7 +537,7 @@ static int ring_desc_ring_alloc(struct pic32_sqi *sqi) > } > > /* Prepare BD: chain to next BD(s) */ > - for (i = 0, rdesc = sqi->ring; i < PESQI_BD_COUNT; i++) > + for (i = 0, rdesc = sqi->ring; i < PESQI_BD_COUNT - 1; i++) > bd[i].bd_nextp = rdesc[i + 1].bd_dma; > bd[PESQI_BD_COUNT - 1].bd_nextp = 0; > Reviewed-by: Purna Chandra Mandal