Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752169AbcDVKsp (ORCPT ); Fri, 22 Apr 2016 06:48:45 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:34002 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbcDVKsn (ORCPT ); Fri, 22 Apr 2016 06:48:43 -0400 Date: Fri, 22 Apr 2016 11:48:37 +0100 From: Mark Brown To: Jon Hunter Cc: Liam Girdwood , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Thierry Reding Message-ID: <20160422104837.GC3217@sirena.org.uk> References: <1461255121-5245-1-git-send-email-jonathanh@nvidia.com> <1461255121-5245-5-git-send-email-jonathanh@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="StZ26hC3DS27TACW" Content-Disposition: inline In-Reply-To: <1461255121-5245-5-git-send-email-jonathanh@nvidia.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1643 Lines: 39 --StZ26hC3DS27TACW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 21, 2016 at 05:12:00PM +0100, Jon Hunter wrote: > A regulator that is in bypass will fail to be registered because we will > attempt to get the voltage of the regulator (ie. it's bypass voltage) > before the supply for the regulator has been resolved. Therefore, when > getting the voltage for a bypassed regulator, if the supply has not been > resolved, then attempt to resolve it. Additionally, move the setup of > the regulator's supply name to before the call to > set_machine_constraints() so that it can be resolved. The basic pattern here makes sense but rather than doing this specifically in the case where we have a bypassed supply we didn't=20 resolve yet I think we should instead always try to resolve the supply but ignore the error unless we actively need the supply. I'd be surprised if we didn't run into other cases where we need to do this so it seems better to try the resolution in one place. --StZ26hC3DS27TACW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXGgGDAAoJECTWi3JdVIfQwI8H/iJMAC2fqr4iE8b8NAsFpFfd Q3g+wmblHmyEPY4LqrEZtJzKAcvwx5I3gWfaj0Ojp/0PJH0iGptJ0K4ZK9cRX8En QV1G6jrlmSzLz1nMzhnYp1huga5PW/sxfLPtnc/cWFV0ItH1eqW+XvMkBYli408v FCy+IFKtFTaFYaB4kK5e5qY5rTLNep33JtdHoc8mScYwAmrd71QfF1v3wiB/Qnf9 8YRvtE3B5EBg4Xo+ZL7nyF5DAWCyxD1jdOFtYhYof0bY9txMa8ewMJ0QArZ39gZy h4OOoG+E5IKJEVZ/TMtj4uGnNls9W0O79WVqjkAj2AJnUT0L96dInhE1Z0NHG7o= =p/OG -----END PGP SIGNATURE----- --StZ26hC3DS27TACW--