Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752082AbcDVL7T (ORCPT ); Fri, 22 Apr 2016 07:59:19 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:34182 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbcDVL7R (ORCPT ); Fri, 22 Apr 2016 07:59:17 -0400 Date: Fri, 22 Apr 2016 13:59:13 +0200 From: Thierry Reding To: Vinay Simha Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "Sumit.semwal" , John Stultz , Archit Taneja Subject: Re: [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings Message-ID: <20160422115913.GH9047@ulmo.ba.sec> References: <20160414171500.GA11505@rob-hp-laptop> <1461144755-10633-1-git-send-email-simhavcs@gmail.com> <1461144755-10633-2-git-send-email-simhavcs@gmail.com> <20160421154546.GA20028@rob-hp-laptop> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cfJ13FhsvNR/yOpm" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3884 Lines: 104 --cfJ13FhsvNR/yOpm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 22, 2016 at 12:25:52PM +0530, Vinay Simha wrote: > On Thu, Apr 21, 2016 at 9:15 PM, Rob Herring wrote: > > On Wed, Apr 20, 2016 at 03:02:31PM +0530, Vinay Simha BN wrote: > >> Add documentation for lt070me05000 panel > >> > >> Signed-off-by: Vinay Simha BN > >> --- > >> .../bindings/display/panel/jdi,lt070me05000.txt | 43 +++++++++++++= +++++++++ > >> 1 file changed, 43 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/display/panel/jd= i,lt070me05000.txt > >> > >> diff --git a/Documentation/devicetree/bindings/display/panel/jdi,lt070= me05000.txt b/Documentation/devicetree/bindings/display/panel/jdi,lt070me05= 000.txt > >> new file mode 100644 > >> index 0000000..ffe0550 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000= =2Etxt > >> @@ -0,0 +1,43 @@ > >> +JDI model LT070ME05000 1200x1920 7" DSI Panel > >> + > >> +Required properties: > >> +- compatible: should be "jdi,lt070me05000" > >> +- power-supply: phandle of the regulator that provides the supply vol= tage > >> + IOVCC , power supply for LCM (1.8V) > >> +- vddp-supply: phandle of the regulator that provides the supply volt= age > >> + Power IC supply (3-5V) > >> +- dcdc_en-supply: phandle of the regulator that provides the supply v= oltage > >> + Power IC supply enable, High active > >> +- reset-gpio: phandle of gpio for reset line > >> + This should be 8mA, gpio can be configured using mux and pinctrl. > >> + XRES, Reset, Low active > >> +- enable-gpio: phandle of gpio for enable line > >> + LED_EN, LED backlight enable, High active > > > > These should all be -gpios instead. > will implement in v3 > > > >> +- vcc-gpio: phandle of regulator/gpio that provides the supply voltage > >> + VDD, LED power supply (3-5V) > > > > Is it a regulator or gpio? > > > VDD is LED power supply, but in nexus 7 2nd gen they are using gpio 23 > instead of regulator. > if we use vcc-supply, not sure we can give the gpio device tree entry > to it in nexus 7 dts. Any inputs ? You can model it as a fixed regulator that's enabled by a GPIO. See: Documentation/devicetree/bindings/regulator/fixed-regulator.txt > >> + > >> +Optional properties: > >> +- pwm-gpio: phandle of gpio/pwm > > > > This should use the PWM binding. It may not be a GPIO on some hosts. >=20 > pwm-gpio will go to the backlight (pwm). right now it is not used > since pwm pm8921 upstream driver is not yet implemented. Shall i > remove this pwm-gpio now and the backlight property when pwm pm8921 is > implemented? This suggests to me that you don't have a good idea yet what the final binding would need to look like, so it might be better to get all the dependencies in place first so that the binding can be validated to work properly. Thierry --cfJ13FhsvNR/yOpm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXGhIQAAoJEN0jrNd/PrOhHBUP+wbmmTsDQ6bizyRTdWfq9GQZ 2n9IPF931PPChZxCLCa3Cp8uaq+g3gmIDtuTy3QWw75RQhk0DN6A0oOaaXq37pQ8 zx3mWIO1+FN4VytccuAcOY4b293FTfZy28nBZWSyvk2vPJv63W3+zj7w1hbf1eda 5Ymc/X7V2vU8ezDeqJutAv9hTzAa/teEQpmHoU8N74oQlphT1s/ofBhBVC4o7KKn HNPityf8mOlY3e7S0z2g1gJ7XZdCyVCJu2ZGQP8bTlPRA+tsd5qejoIhgdQFtkdc HfnbfB/AGOykN3X2YhNu54PfOlHBDFI1V2SPdBXXpppL4h4CgHm9BlJwiV1NWBG3 D9W3Gn/n1RXx5/ObIQ4AglR+thA0cFvynl8PJtUnnzmp9dF/509ZwUpZ22ABhLe5 ue4DNn+NNEV55EiZIUEYiFnYVRnJ9Jv5JWinEUvIBHV4Qnc15cVLfQaz9xI3gd7d 2AF8+ARAcLaa/Q2n9zGASHuLSORtfAY8xTWJ+c3DRekNuj3vVUM9N6m60m02F3wJ lMAiDuLo3cpqEn9qF6P8wiZ9t288+Ckt0U+uwP55yKv0eEDm28638z/2DiD/lQ1G 9Bqs5k/b4C9FXfLCxoTB0EdkMuyn5tpYxEj79qTv6286sZe15PBlp4spxOVnxgIw ZX3WZUSJV7FHNm3Ebx56 =jywe -----END PGP SIGNATURE----- --cfJ13FhsvNR/yOpm--