Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753331AbcDVN16 (ORCPT ); Fri, 22 Apr 2016 09:27:58 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:45246 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752669AbcDVN15 (ORCPT ); Fri, 22 Apr 2016 09:27:57 -0400 Message-ID: <1461331670.16530.10.camel@mtksdaap41> Subject: Re: [PATCH 3/3] checkpatch: relax Kconfig help text line number threshold From: Yingjoe Chen To: Andi Kleen CC: Joe Perches , Andy Whitcroft , , Date: Fri, 22 Apr 2016 21:27:50 +0800 In-Reply-To: <20160421173926.GB19706@tassilo.jf.intel.com> References: <1461245285-14918-1-git-send-email-yingjoe.chen@mediatek.com> <1461245285-14918-3-git-send-email-yingjoe.chen@mediatek.com> <1461258007.1918.12.camel@perches.com> <20160421173926.GB19706@tassilo.jf.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1306 Lines: 34 On Thu, 2016-04-21 at 10:39 -0700, Andi Kleen wrote: > On Thu, Apr 21, 2016 at 10:00:07AM -0700, Joe Perches wrote: > > On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote: > > > Current threshold is too strict and many upstream patch doesn't pass > > > this test. Relax it. > > > > I don't have an issue with this. > > Maybe Andi Kleen does though. > > So you spend all this time developing your kernel feature and can't be bothered to > write a real description? How should people even find out about it? I think it depends. For some features it would be helpful to have more description. However for many device drivers, 2 lines is enough. For example, I think the following help text is helpful and clean. +config PINCTRL_IPQ4019 + tristate "Qualcomm IPQ4019 pin controller driver" + depends on GPIOLIB && OF + select PINCTRL_MSM + help + This is the pinctrl, pinmux, pinconf and gpiolib driver for the + Qualcomm TLMM block found in the Qualcomm IPQ4019 platform. + +config SND_SOC_PCM179X_I2C + tristate "Texas Instruments PCM179X CODEC (I2C)" + depends on I2C + select SND_SOC_PCM179X + help + Enable support for Texas Instruments PCM179x CODEC. + Select this if your PCM179x is connected via an I2C bus. Joe.C