Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049AbcDVN5S (ORCPT ); Fri, 22 Apr 2016 09:57:18 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:34576 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942AbcDVN5R (ORCPT ); Fri, 22 Apr 2016 09:57:17 -0400 Date: Fri, 22 Apr 2016 14:57:09 +0100 From: Mark Brown To: Richard Fitzgerald Cc: lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Message-ID: <20160422135709.GE3217@sirena.org.uk> References: <1461331982-30960-1-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9v+t0xRk6rtskISq" Content-Disposition: inline In-Reply-To: <1461331982-30960-1-git-send-email-rf@opensource.wolfsonmicro.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: core: Add debugfs for regulator always_on flag X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1480 Lines: 39 --9v+t0xRk6rtskISq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 22, 2016 at 02:33:02PM +0100, Richard Fitzgerald wrote: > This patch adds a debugfs file for the always_on flag in struct regulator. > It's useful for debugging to be able to view the state of this flag and > as it's set by logic inside the regulator core it doesn't necessarily have > the same value as the always_on flag in constraints. Why not include this in the same file as the rest of the constraints? Or why not have one file per constraint (which would be easier for scripts)? > + ret = snprintf(buf, PAGE_SIZE, "always_on: %u\n", regulator->always_on); > + debugfs_create_file("always_on", 0444, regulator->debugfs, It seems to be formatted as though it's going to end up in the same file but it's a separate file so instead it's just repeating the name of the file inside the file. --9v+t0xRk6rtskISq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXGi20AAoJECTWi3JdVIfQv0kH/i8UZ2+YArmdRO43xcwdWEa/ W87rPhvwYR9lieWu6eE3LoD0MNuDQ4ROd5MRxSH/AXnQaPuDKJLFLts8rA0RPRg4 /aRPmkt/zW9Kt4YRmmH783Cl42cC/QxydBXPbmOxt8TScws0W318jLcAYwDXI3A7 MgNCdsUun8QERQS/4h/XmANUdYkPfLYKMW4cZk5PrsAfvWan1GViLRG5sIH+YwrG a7Gt3iIYpS8c2LptpRan6sHAoXhJ0na5pKus8//4HITBLpwARWDEYXS4b8pZDNCq eJnzF5PH9saT16n3BhR04K3qAfQ8Z/N5k3hUwJxKW8r025rmjTuHA1XFn17l7Fs= =0YRs -----END PGP SIGNATURE----- --9v+t0xRk6rtskISq--