Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753996AbcDVOBx (ORCPT ); Fri, 22 Apr 2016 10:01:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:56247 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbcDVOBv (ORCPT ); Fri, 22 Apr 2016 10:01:51 -0400 Date: Fri, 22 Apr 2016 16:01:48 +0200 From: Johannes Thumshirn To: Laurence Oberman Cc: Johannes Thumshirn , "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Laura Abbott , Michael Reed , stable@vger.kernel.org Subject: Re: [PATCH] qla1280: Reduce can_queue to 32 Message-ID: <20160422140148.GV28402@c203.arch.suse.de> References: <1461310270-8945-1-git-send-email-jthumshirn@suse.de> <668592243.31153125.1461327404017.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <668592243.31153125.1461327404017.JavaMail.zimbra@redhat.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6867 Lines: 125 On Fri, Apr 22, 2016 at 08:16:44AM -0400, Laurence Oberman wrote: > The change looks fine, I see its hard-coded to 32 in qla1280_set_defaults() > Would it be better to create a #define like other drivers and use that in both. > Also did the below patch resolve this for the bug reporter. Yes, that's probably a reasonable idea, I'll re-send. > I ask because if I check 4.3 it was also set to the same value of 0xfffff and that is reported as working. > So other changes in 4.4 must be "abusing" this high value. I think it was introduced with commit 64d513ac31b - "scsi: use host wide tags by default". Since this commit scsi_add_host_with_dma() directly calls blk_init_tags() instead of scsi_init_shared_tag_map(). The qla1280 driver has never set up the block tags though, so the bogus value was not a problem. That at least is my analysis, feel free to correct my assumptions. > > Reviewed-by Laurence Oberman > > Laurence Oberman > Principal Software Maintenance Engineer > Red Hat Global Support Services > > ----- Original Message ----- > From: "Johannes Thumshirn" > To: "Martin K . Petersen" , "James E . J . Bottomley" > Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Johannes Thumshirn" , "Laura Abbott" , "Michael Reed" , stable@vger.kernel.org > Sent: Friday, April 22, 2016 3:31:10 AM > Subject: [PATCH] qla1280: Reduce can_queue to 32 > > It was reported in https://bugzilla.redhat.com/show_bug.cgi?id=1321033, > that the qla1280 driver sets the scsi_host_template's can_queue field > to 0xfffff which results in an allocation failure when allocating the > block layer tags for the driver's queues like the one shown below: > > [ 4.804166] scsi host0: QLogic QLA1040 PCI to SCSI Host Adapter Firmware version: 7.65.06, Driver version 3.27.1 > [ 4.804174] ------------[ cut here ]------------ > [ 4.804184] WARNING: CPU: 2 PID: 305 at mm/page_alloc.c:2989 alloc_pages_nodemask+0xae8/0xbc0() > [ 4.804186] Modules linked in: amdkfd amd_iommu_v2 radeon i2c_algo_bit m_kms_helper ttm drm megaraid_sas serio_raw 8021q garp bnx2 stp llc mrp nhme qla1280(+) fjes > [ 4.804208] CPU: 2 PID: 305 Comm: systemd-udevd Not tainted 4.6-201.fc22.x86_64 #1 > [ 4.804210] Hardware name: Google Enterprise Search Appliance/0DT021, OS 1.1.2 08/14/2006 > [ 4.804212] 0000000000000286 000000002f01064c ffff88042985b710 ffffff813b542e > [ 4.804216] 0000000000000000 ffffffff81a75024 ffff88042985b748 ffffff810a40f2 > [ 4.804220] 0000000000000000 0000000000000000 000000000000000b 00000000000000 > [ 4.804223] Call Trace: > [ 4.804231] [] dump_stack+0x63/0x85 > [ 4.804236] [] warn_slowpath_common+0x82/0xc0 > [ 4.804239] [] warn_slowpath_null+0x1a/0x20 > [ 4.804242] [] __alloc_pages_nodemask+0xae8/0xbc0 > [ 4.804247] [] ? _raw_spin_unlock_irqrestore+0xe/0x10 > [ 4.804251] [] ? irq_work_queue+0x8e/0xa0 > [ 4.804256] [] ? console_unlock+0x20a/0x540 > [ 4.804262] [] alloc_pages_current+0x8c/0x110 > [ 4.804265] [] alloc_kmem_pages+0x19/0x90 > [ 4.804268] [] kmalloc_order_trace+0x2e/0xe0 > [ 4.804272] [] __kmalloc+0x232/0x260 > [ 4.804277] [] init_tag_map+0x3d/0xc0 > [ 4.804290] [] __blk_queue_init_tags+0x45/0x80 > [ 4.804293] [] blk_init_tags+0x14/0x20 > [ 4.804298] [] scsi_add_host_with_dma+0x80/0x300 > [ 4.804305] [] qla1280_probe_one+0x683/0x9ef [qla1280] > [ 4.804309] [] local_pci_probe+0x45/0xa0 > [ 4.804312] [] pci_device_probe+0xfd/0x140 > [ 4.804316] [] driver_probe_device+0x222/0x490 > [ 4.804319] [] __driver_attach+0x84/0x90 > [ 4.804321] [] ? driver_probe_device+0x490/0x490 > [ 4.804324] [] bus_for_each_dev+0x6c/0xc0 > [ 4.804326] [] driver_attach+0x1e/0x20 > [ 4.804328] [] bus_add_driver+0x1eb/0x280 > [ 4.804331] [] ? 0xffffffffa0015000 > [ 4.804333] [] driver_register+0x60/0xe0 > [ 4.804336] [] __pci_register_driver+0x4c/0x50 > [ 4.804339] [] qla1280_init+0x1ce/0x1000 [qla1280] > [ 4.804341] [] ? 0xffffffffa0015000 > [ 4.804345] [] do_one_initcall+0xb3/0x200 > [ 4.804348] [] ? kmem_cache_alloc_trace+0x196/0x210 > [ 4.804352] [] ? do_init_module+0x27/0x1cb > [ 4.804354] [] do_init_module+0x5f/0x1cb > [ 4.804358] [] load_module+0x2040/0x2680 > [ 4.804360] [] ? __symbol_put+0x60/0x60 > [ 4.804363] [] SYSC_init_module+0x149/0x190 > [ 4.804366] [] SyS_init_module+0xe/0x10 > [ 4.804369] [] entry_SYSCALL_64_fastpath+0x12/0x71 > [ 4.804371] ---[ end trace 0ea3b625f86705f7 ]--- > [ 4.804581] qla1280: probe of 0000:11:04.0 failed with error -12 > > In qla1280_set_defaults() the maximum queue depth is > set to 32 so adopt the scsi_host_template to it as well. > > Signed-off-by: Johannes Thumshirn > Cc: Laura Abbott > Cc: Michael Reed > Cc: stable@vger.kernel.org > --- > drivers/scsi/qla1280.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c > index 5d0ec42..6bd748e 100644 > --- a/drivers/scsi/qla1280.c > +++ b/drivers/scsi/qla1280.c > @@ -4214,7 +4214,7 @@ static struct scsi_host_template qla1280_driver_template = { > .eh_bus_reset_handler = qla1280_eh_bus_reset, > .eh_host_reset_handler = qla1280_eh_adapter_reset, > .bios_param = qla1280_biosparam, > - .can_queue = 0xfffff, > + .can_queue = 32, > .this_id = -1, > .sg_tablesize = SG_ALL, > .use_clustering = ENABLE_CLUSTERING, > -- > 2.8.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850