Subject: Re: [PATCH V6 08/13] PCI: generic, thunder: update to use generic
 ECAM API
To: Tomasz Nowicki <tn@semihalf.com>, Arnd Bergmann <arnd@arndb.de>
References: <1460740008-19489-1-git-send-email-tn@semihalf.com>
 <3830999.dF71UWYsBP@wuerfel> <57189D2F.9070802@semihalf.com>
 <8950494.UV8UrWiFbx@wuerfel> <5718A6AE.4080203@semihalf.com>
Cc: Jayachandran C <jchandra@broadcom.com>,
        linux-arm-kernel@lists.infradead.org,
        Bjorn Helgaas <helgaas@kernel.org>, Will Deacon <will.deacon@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>, rafael@kernel.org,
        Hanjun Guo <hanjun.guo@linaro.org>,
        Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
        Sinan Kaya <okaya@codeaurora.org>, jiang.liu@linux.intel.com,
        linaro-acpi@lists.linaro.org, linux-pci@vger.kernel.org,
        Liviu.Dudau@arm.com, David Daney <ddaney@caviumnetworks.com>,
        linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
        robert.richter@caviumnetworks.com, Suravee.Suthikulpanit@amd.com,
        msalter@redhat.com, Wangyijing <wangyijing@huawei.com>,
        Marcin Wojtas <mw@semihalf.com>
From: Jon Masters <jcm@redhat.com>
Message-ID: <571A3587.2020704@redhat.com>
Date: Fri, 22 Apr 2016 10:30:31 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <5718A6AE.4080203@semihalf.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1725
Lines: 38

On 04/21/2016 06:08 AM, Tomasz Nowicki wrote:
> On 21.04.2016 11:36, Arnd Bergmann wrote:
>> On Thursday 21 April 2016 11:28:15 Tomasz Nowicki wrote:
>>> On 19.04.2016 15:06, Arnd Bergmann wrote:
>>>> On Monday 18 April 2016 21:31:54 Tomasz Nowicki wrote:
>>>>>
>>>>> Basically the whole content of pci-thunder-ecam.c and
>>>>> pci-thunder-pem.c.
>>>>>
>>>>> pci-thunder-ecam.c contains config space accessors. Similar for
>>>>> pci-thunder-pem.c but it also has extra init call (it is now called
>>>>> thunder_pem_init) which finds and maps related registers.
>>>>
>>>> They seem to do much more than just override the accessors, they
>>>> actually
>>>> change the contents of the config space as well. Is that really
>>>> necessary
>>>> on ACPI based systems as well?
>>>
>>> Yes, the pci-thunder-ecam.c accessors are meant to emulate config space
>>> capabilities. They are necessary to synthesize EA capabilities (fixed
>>> PCI BARs), it wont work without this, for ACPI boot as well.
>>
>> Why is that? I thought the BARs never get reassigned when using ACPI,
>> so I'm surprised it's actually needed. Maybe I misunderstood what
>> you mean by fixed PCI BARs.
> 
> Yes, I meant something else. ThunderX has non-programmable PCI BAR
> addresses. So it uses PCI EA (Extended allocation) capabilities to get
> know PCI BARs addresses. But the early implementation (pass1.x) misses
> EA capabilities hence we need to emulate it in config space accessors.

Aside: In case it's helpful, at least one enterprise vendor I know of is
only supporting later silicon as a result of this. So IMO there's no
need to worry about this issue on the early preproduction chips.

-- 
Computer Architect | Sent from my Fedora powered laptop