Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754247AbcDVOcU (ORCPT ); Fri, 22 Apr 2016 10:32:20 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:47510 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753336AbcDVOcT (ORCPT ); Fri, 22 Apr 2016 10:32:19 -0400 From: Yingjoe Chen To: Andy Whitcroft , Joe Perches CC: , Andi Kleen , Paul Bolle , , Yingjoe Chen Subject: [PATCH v2 1/3] checkpatch: add Kconfig 'default n' test Date: Fri, 22 Apr 2016 22:32:05 +0800 Message-ID: <1461335527-19270-1-git-send-email-yingjoe.chen@mediatek.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 33 If a Kconfig config option doesn't specify 'default', the default will be n. Adding 'default n' is unnecessary. Add a test to warn about this. Signed-off-by: Yingjoe Chen --- Change in v2: - Change according to Joe Perches' suggestion scripts/checkpatch.pl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d574d13..3cb7c2d 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2600,6 +2600,13 @@ sub process { "Use of boolean is deprecated, please use bool instead.\n" . $herecurr); } +# discourage the use of default n + if ($realfile =~ /Kconfig/ && + $line =~ /^\+\s*default\s*n\s*(#.*|$)/i) { + WARN("CONFIG_DEFAULT_N", + "Use of default n is unnecessary, default is n when omitted.\n" . $herecurr); + } + if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) && ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) { my $flag = $1; -- 1.9.1