Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754106AbcDVOkS (ORCPT ); Fri, 22 Apr 2016 10:40:18 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:9316 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752055AbcDVOkQ (ORCPT ); Fri, 22 Apr 2016 10:40:16 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 22 Apr 2016 07:40:04 -0700 Subject: Re: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id To: Shardar Mohammed , Laxman Dewangan , "vinod.koul@intel.com" , "dan.j.williams@intel.com" , "swarren@wwwdotorg.org" , "thierry.reding@gmail.com" , "gnurou@gmail.com" , "dmaengine@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <1461329093-20300-1-git-send-email-smohammed@nvidia.com> <571A2819.9000507@nvidia.com> <36d59e91fa72417d94ae2672e423ebb4@bgmail102.nvidia.com> From: Jon Hunter Message-ID: <571A37CA.5080001@nvidia.com> Date: Fri, 22 Apr 2016 15:40:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <36d59e91fa72417d94ae2672e423ebb4@bgmail102.nvidia.com> X-Originating-IP: [10.21.132.108] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2921 Lines: 80 On 22/04/16 14:56, Shardar Mohammed wrote: > Thanks for the review, please check my comments inline in [Shardar]. > >> On 22/04/16 13:44, Shardar Shariff Md wrote: >>> Initialize default channel slave_id(req_sel) to invalid id (i.e max >>> supported slave id + 1) to avoid overwriting of slave_id during >>> tegra_dma_slave_config() with client data if slave_id is not >>> initialized through DT >>> >>> Signed-off-by: Shardar Shariff Md >>> >>> --- >>> - Instead of initializing the slave id to -1 define macros for >>> max slave id and invalid slave id and do the checks accordingly. >>> --- >>> drivers/dma/tegra20-apb-dma.c | 13 +++++++++++-- >>> 1 file changed, 11 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/dma/tegra20-apb-dma.c >>> b/drivers/dma/tegra20-apb-dma.c index 3871f29..2957e26 100644 >>> --- a/drivers/dma/tegra20-apb-dma.c >>> +++ b/drivers/dma/tegra20-apb-dma.c >>> @@ -114,6 +114,9 @@ >>> /* Channel base address offset from APBDMA base address */ >>> #define TEGRA_APBDMA_CHANNEL_BASE_ADD_OFFSET 0x1000 >>> >>> +#define TEGRA_APBDMA_SLAVE_ID_MAX 31 >> >> Sorry, thinking about this some more, given that the ID is programmed into a >> field in the CSR register could we just define as mask here for the CSR field ... >> >> #define TEGRA_APBDMA_CSR_REQ_SEL_MASK 0x1f >> >> Note this should be defined with the other CSR register field definitions. > [Shardar] Will take care of it. One doubt do you mean below. > Will define this with other CSR register fields. > #define TEGRA_APBDMA_CSR_REQ_SEL_MASK 0x1f > > #define TEGRA_APBDMA_SLAVE_ID_MAX TEGRA_APBDMA_CSR_REQ_SEL_MASK We don't need the MAX definition as well. >> >>> +#define TEGRA_APBDMA_SLAVE_ID_INVALID >> (TEGRA_APBDMA_SLAVE_ID_MAX + 1) >>> >>> struct tegra_dma; >>> >>> /* >>> @@ -353,7 +356,7 @@ static int tegra_dma_slave_config(struct dma_chan >> *dc, >>> } >>> >>> memcpy(&tdc->dma_sconfig, sconfig, sizeof(*sconfig)); >>> - if (!tdc->slave_id) >>> + if (tdc->slave_id == TEGRA_APBDMA_SLAVE_ID_INVALID) >>> tdc->slave_id = sconfig->slave_id; >> >> I believe I mentioned before that here we should ... >> >> if (tdc->slave_id != TEGRA_APBDMA_SLAVE_ID_INVALID) >> return -EBUSY; > > [Shardar] By the time this function tegra_dma_slave_config is called, slave_id here is already initialized through DT(provided option) through function tegra_dma_of_xlate(). > And filling up the slave id here from sconfig structure that is provided by dma client driver is used here if it dma client is not initialized through DT. > Please correct me if am wrong. Yes you are right. So on further inspection this allows the user to set the slave ID if it is not set yet. So I think we need ... if (tdc->slave_id == TEGRA_APBDMA_SLAVE_ID_INVALID) { if (sconfig->slave_id > TEGRA_APBDMA_CSR_REQ_SEL_MASK) return -EINVAL; else tdc->slave_id = sconfig->slave_id; } Cheers Jon