Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754260AbcDVPFA (ORCPT ); Fri, 22 Apr 2016 11:05:00 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:34684 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761AbcDVPE7 (ORCPT ); Fri, 22 Apr 2016 11:04:59 -0400 Date: Fri, 22 Apr 2016 16:04:46 +0100 From: Mark Brown To: Richard Fitzgerald Cc: lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Message-ID: <20160422150446.GF3217@sirena.org.uk> References: <1461332608-14760-1-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4+GP5VtpSFAXb8tV" Content-Disposition: inline In-Reply-To: <1461332608-14760-1-git-send-email-rf@opensource.wolfsonmicro.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: arizona-ldo1: Only enable status change if we have LDOENA X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1315 Lines: 34 --4+GP5VtpSFAXb8tV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 22, 2016 at 02:43:28PM +0100, Richard Fitzgerald wrote: > The driver was hardcoding REGULATOR_CHANGE_STATUS on the regulator > which made the regulator core assume that it can be powered off. >=20 > The power state of the regulator is controlled by the LDOENA pin so > this patch changes to only setting the REGULATOR_CHANGE_STATUS flag > if we have a valid gpio for LDOENA. What's the difference between this and the previous version of the patch and what problem is this aiming to solve? If we want to disable the regulator why would we not be happy to do that by removing the supply? --4+GP5VtpSFAXb8tV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXGj2NAAoJECTWi3JdVIfQ76oH+QGovWT2SqxL+arsnymAJ+tX +QZWNmekMU8UhH1NhRp/64+ZcI9e925h7rzVcM+WI+leKXDESE1Y1LPHMtAlxZvo Kxjn7hvqAcpSrSpF+5fJOVE+XZdIHNZrSwNPZj5br9gOvQcx0a26ykY4l89EEIPi Kozj5OhecyIs1ro54CJuQkF4jyQPr35jgTtqSxsSs5fYlSfONn1fVYsTdf89takC DZudr5dosT0WEsRYpXGbx3HBOCZqGcqQ70vk2mAo7SWT1/Ck12EczqRsUoyJ2Wfv 5Oiu3g99jZTT9+IrDZt1gWrwG+y5k2FrYig1mp6zMDFDfAoj5Tx3RdppIF3bqhg= =tvFL -----END PGP SIGNATURE----- --4+GP5VtpSFAXb8tV--