Subject: Re: [PATCH] irqdomain: fix compare_const_fl.cocci warnings
To: Julia Lawall <julia.lawall@lip6.fr>, Jiang Liu <jiang.liu@linux.intel.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        "Thomas Gleixner" <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>,
        <kbuild-all@01.org>
References: <alpine.DEB.2.10.1604201848270.3089@hadrien>
From: Jon Hunter <jonathanh@nvidia.com>
Message-ID: <571A6BAF.8040006@nvidia.com>
Date: Fri, 22 Apr 2016 19:21:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.10.1604201848270.3089@hadrien>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1071
Lines: 35


On 20/04/16 17:49, Julia Lawall wrote:
>  Move constants to the right of binary operators.
> 
> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> 
> Not a big deal, but the transformed code looks better to me.
> 
>  irqdomain.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -618,7 +618,7 @@ unsigned int irq_create_fwspec_mapping(s
>  		 * If the trigger type has not been set yet, then set
>  		 * it now and return the interrupt number.
>  		 */
> -		if (IRQ_TYPE_NONE == irq_get_trigger_type(virq)) {
> +		if (irq_get_trigger_type(virq) == IRQ_TYPE_NONE) {
>  			irq_set_irq_type(virq, type);
>  			return virq;
>  		}

What branch is this from? Looks very familiar and related to some
changes I have been working on, but in my latest version I already have
this as shown above [0].

Cheers
Jon

[0] http://marc.info/?l=linux-tegra&m=146115064322071&w=2