Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbcDVVuA (ORCPT ); Fri, 22 Apr 2016 17:50:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36951 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbcDVVt6 (ORCPT ); Fri, 22 Apr 2016 17:49:58 -0400 Date: Fri, 22 Apr 2016 14:49:57 -0700 From: Andrew Morton To: Chris Wilson Cc: Roman Peniaev , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Tvrtko Ursulin , Daniel Vetter , David Rientjes , Joonsoo Kim , Mel Gorman , Toshi Kani , Shawn Lin , linux-mm@kvack.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mm/vmalloc: Keep a separate lazy-free list Message-Id: <20160422144957.64619ee9b19991e4fdf89668@linux-foundation.org> In-Reply-To: <20160415111431.GL19990@nuc-i3427.alporthouse.com> References: <1460444239-22475-1-git-send-email-chris@chris-wilson.co.uk> <20160414134926.GD19990@nuc-i3427.alporthouse.com> <20160415111431.GL19990@nuc-i3427.alporthouse.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 723 Lines: 19 On Fri, 15 Apr 2016 12:14:31 +0100 Chris Wilson wrote: > > > purge_fragmented_blocks() manages per-cpu lists, so that looks safe > > > under its own rcu_read_lock. > > > > > > Yes, it looks feasible to remove the purge_lock if we can relax sync. > > > > what is still left is waiting on vmap_area_lock for !sync mode. > > but probably is not that bad. > > Ok, that's bit beyond my comfort zone with a patch to change the free > list handling. I'll chicken out for the time being, atm I am more > concerned that i915.ko may call set_page_wb() frequently on individual > pages. Nick Piggin's vmap rewrite. 20x (or more) faster. https://lwn.net/Articles/285341/ 10 years ago, never finished.