Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753864AbcDVWSg (ORCPT <rfc822;w@1wt.eu>);
	Fri, 22 Apr 2016 18:18:36 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44643 "EHLO
	out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753656AbcDVWSO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 22 Apr 2016 18:18:14 -0400
X-Sasl-enc: 6Nzaiqy0/E1o5WdrrNEkimuDo3ifOQzOa2eXJC6Y0dfP 1461363493
Date: Sat, 23 Apr 2016 07:18:10 +0900
From: Greg KH <greg@kroah.com>
To: Bruce Rogers <brogers@suse.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, namit@cs.technion.ac.il,
        stable@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: fix ordering of cr0 initialization code in
 vmx_cpu_reset
Message-ID: <20160422221810.GA10089@kroah.com>
References: <1461351363-28094-1-git-send-email-brogers@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1461351363-28094-1-git-send-email-brogers@suse.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 946
Lines: 23

On Fri, Apr 22, 2016 at 12:56:03PM -0600, Bruce Rogers wrote:
> Commit d28bc9dd25ce reversed the order of two lines which initialize cr0,
> allowing the current (old) cr0 value to mess up vcpu initialization.
> This was observed in the checks for cr0 X86_CR0_WP bit in the context of
> kvm_mmu_reset_context(). Besides, setting vcpu->arch.cr0 after vmx_set_cr0()
> is completely redundant. Change the order back to ensure proper vcpu
> initialization.
> 
> The combination of booting with ovmf firmware when guest vcpus > 1 and kvm's
> ept=N option being set results in a VM-entry failure. This patch fixes that.
> 
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
>  arch/x86/kvm/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>