Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753332AbcDVWYv (ORCPT ); Fri, 22 Apr 2016 18:24:51 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58799 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219AbcDVWYu (ORCPT ); Fri, 22 Apr 2016 18:24:50 -0400 Date: Fri, 22 Apr 2016 15:24:47 -0700 From: Stephen Boyd To: Viresh Kumar Cc: Rafael Wysocki , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, nm@ti.com, arnd.bergmann@linaro.org, thomas.petazzoni@free-electrons.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/10] mvebu: Use dev_pm_opp_set_sharing_cpus() to mark OPP tables as shared Message-ID: <20160422222447.GS13149@codeaurora.org> References: <3808dbeda9c233026ed78fa3ec94c0bbd898875c.1461228504.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3808dbeda9c233026ed78fa3ec94c0bbd898875c.1461228504.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 495 Lines: 15 On 04/21, Viresh Kumar wrote: > @@ -683,10 +678,15 @@ static int __init armada_xp_pmsu_cpufreq_init(void) > clk_put(clk); > return ret; > } > + > + ret = dev_pm_opp_set_sharing_cpus(cpu_dev, > + (struct cpumask *) cpumask_of(cpu_dev->id)); This cast doesn't look good. Why are we casting away const? Shouldn't dev_pm_opp_set_sharing_cpus() take a const mask anyway? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project