Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752914AbcDVXaJ (ORCPT ); Fri, 22 Apr 2016 19:30:09 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54009 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751800AbcDVXaH (ORCPT ); Fri, 22 Apr 2016 19:30:07 -0400 Date: Sat, 23 Apr 2016 01:29:46 +0200 From: Alexandre Belloni To: =?iso-8859-1?Q?Myl=E8ne?= Josserand Cc: rtc-linux@googlegroups.com, Alessandro Zummo , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] rtc: rv3029: Removes some checks and warnings Message-ID: <20160422232946.GF17051@piout.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 512 Lines: 23 Hi, On 21/04/2016 at 20:24:17 +0200, Myl?ne Josserand wrote : > @@ -829,8 +829,6 @@ static void rv3029_unregister_driver(void) > > static int rv3049_probe(struct spi_device *spi) > { > - int res; > - unsigned int tmp; Well, you just introduced those variables in the previous patch. > static const struct regmap_config config = { > .reg_bits = 8, > .val_bits = 8, > -- > 2.8.0.rc3 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com