Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751633AbcDWGsF (ORCPT ); Sat, 23 Apr 2016 02:48:05 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:36009 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751224AbcDWGsD (ORCPT ); Sat, 23 Apr 2016 02:48:03 -0400 Date: Sat, 23 Apr 2016 12:17:45 +0530 From: Afzal Mohammed To: Dan Carpenter Cc: Marcel Holtmann , Gustavo Padovan , Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] Bluetooth: ath3k: Silence uninitialized variable warning Message-ID: <20160423064745.GA4826@afzalpc> References: <20160422100255.GE11398@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160422100255.GE11398@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 451 Lines: 18 Hi, On Fri, Apr 22, 2016 at 01:02:55PM +0300, Dan Carpenter wrote: > - int err, pipe, len, size, count, sent = 0; > + int len = 0; > + int err, pipe, size, count, sent = 0; Is there any particular reason to avoid more than 1 variable initialization in definition on a single line ?, like, int err, pipe, size, count, sent = 0, len = 0; have observed that none of your uninitialized variable warning fixes does as mentioned above. Regards afzal