Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbcDXAJO (ORCPT ); Sat, 23 Apr 2016 20:09:14 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:40305 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751706AbcDXAJN (ORCPT ); Sat, 23 Apr 2016 20:09:13 -0400 Subject: Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted To: Guan Xuetao References: <1458559253-422-1-git-send-email-linux@roeck-us.net> Cc: linux-kernel@vger.kernel.org, Dave Hansen , Thomas Gleixner , Ingo Molnar From: Guenter Roeck Message-ID: <571C0EA5.3090104@roeck-us.net> Date: Sat, 23 Apr 2016 17:09:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458559253-422-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 38 ping ... still not upstream. On 03/21/2016 04:20 AM, Guenter Roeck wrote: > unicore32 fails to compile with the following errors. > > mm/memory.c: In function ‘__handle_mm_fault’: > mm/memory.c:3381: error: > too many arguments to function ‘arch_vma_access_permitted’ > mm/gup.c: In function ‘check_vma_flags’: > mm/gup.c:456: error: > too many arguments to function ‘arch_vma_access_permitted’ > mm/gup.c: In function ‘vma_permits_fault’: > mm/gup.c:640: error: > too many arguments to function ‘arch_vma_access_permitted’ > > Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction fetches") > Cc: Dave Hansen > Cc: Thomas Gleixner > Cc: Ingo Molnar > Signed-off-by: Guenter Roeck > --- > arch/unicore32/include/asm/mmu_context.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/unicore32/include/asm/mmu_context.h b/arch/unicore32/include/asm/mmu_context.h > index e35632ef23c7..62dfc644c908 100644 > --- a/arch/unicore32/include/asm/mmu_context.h > +++ b/arch/unicore32/include/asm/mmu_context.h > @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm, > } > > static inline bool arch_vma_access_permitted(struct vm_area_struct *vma, > - bool write, bool foreign) > + bool write, bool execute, bool foreign) > { > /* by default, allow everything */ > return true; >