Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752188AbcDXCpz (ORCPT ); Sat, 23 Apr 2016 22:45:55 -0400 Received: from mail1.windriver.com ([147.11.146.13]:57272 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbcDXCpy (ORCPT ); Sat, 23 Apr 2016 22:45:54 -0400 From: Paul Gortmaker To: CC: Paul Gortmaker , Christoph Hellwig , Ming Lin , Sagi Grimberg , "Martin K . Petersen" Subject: [PATCH v2] lib: make sg_pool tristate instead of bool Date: Sat, 23 Apr 2016 22:44:55 -0400 Message-ID: <1461465895-676-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.8.0 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1784 Lines: 52 The recently added Kconfig controlling compilation of this code is: lib/Kconfig:config SG_POOL lib/Kconfig: def_bool n ...meaning that it currently is not being built as a module by anyone, and that tripped my audit looking for modular code that is essentially orphaned (i.e. module_exit, and .remove fcns in non-modular drivers.) In the following discussion, Ming Lin indicated that the original intention was to have it tristate, so here we convert it accordingly. Also fix up a couple spelling issues that appear in the surrounding patch context. Cc: Christoph Hellwig Cc: Ming Lin Cc: Sagi Grimberg Cc: Martin K. Petersen Signed-off-by: Paul Gortmaker --- [v2: drop modular code removal patch in favour of supporting a modular build via a one line Kconfig patch as per Ming's comments. Build tested for allmodconfig on ARM and x86-64 on linux-next. ] lib/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Kconfig b/lib/Kconfig index e04f168f8f42..8de5868804b5 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -528,13 +528,13 @@ config SG_SPLIT help Provides a helper to split scatterlists into chunks, each chunk being a scatterlist. This should be selected by a driver or an API which - whishes to split a scatterlist amongst multiple DMA channels. + wishes to split a scatterlist amongst multiple DMA channels. config SG_POOL - def_bool n + def_tristate n help Provides a helper to allocate chained scatterlists. This should be - selected by a driver or an API which whishes to allocate chained + selected by a driver or an API which wishes to allocate chained scatterlist. # -- 2.8.0