Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752833AbcDXPK6 (ORCPT ); Sun, 24 Apr 2016 11:10:58 -0400 Received: from mail.kernel.org ([198.145.29.136]:56264 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752620AbcDXPK5 (ORCPT ); Sun, 24 Apr 2016 11:10:57 -0400 Date: Sun, 24 Apr 2016 17:10:52 +0200 From: Sebastian Reichel To: Joe Perches Cc: changbin.du@intel.com, apw@canonical.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] checkpatch.pl: add support for checking patch from git repository Message-ID: <20160424151052.GA12279@earth> References: <1461494406-30000-1-git-send-email-changbin.du@intel.com> <1461496965.2726.50.camel@perches.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zYM0uCDKw75PZbzx" Content-Disposition: inline In-Reply-To: <1461496965.2726.50.camel@perches.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1826 Lines: 49 --zYM0uCDKw75PZbzx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Apr 24, 2016 at 04:22:45AM -0700, Joe Perches wrote: > On Sun, 2016-04-24 at 18:40 +0800, changbin.du@intel.com wrote: > > From: "Du, Changbin" > >=20 > > This patch add "-g, --git" option that tread FILE as git commits > > expression. You can specify the git commit hash ID expressions, > > then these commits from your git repository will be checked. >=20 > Why would anyone want to use checkpatch on commits already in git? It may be in some non-public development branch. Usually when I write patches I open a file, change it and commit the result or even interim result to have backups and other git features available as soon as possible. All testing is done later. So IMHO this is a really useful feature. -- Sebastian --zYM0uCDKw75PZbzx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXHOH3AAoJENju1/PIO/qaCz0P/02sHXHh1zVl5FFQZJB+dziQ 5KGrXEB5FbcDkmkiblValBse/b8bXPyZpTTIKOzzww78aQzuZglppckR9tQvtxuL os8jHGEQllGiUwSdYLSv99/e6rsAbFWmO0gl6zh4hQe26nDlUUb6YOGaxGWwpYKt MyOLYbEBGEruDsEloq1c3RemnCjOAAAae0ba7YTwxfJzO+hVpHU23kYeQI2j2z/7 itXmakPD98rfKsbfdfEl9fZiP3iC3TzrcgB4y0jgOxIwWq7wZttlt7TXjM8HKI62 OKxK9cp0ckGBKnOEGgUI5MoUdMBZDCUdsMmGbFGfZqeSxEJnP/lx7oZ/6U7YXYdh ukxiSgzaHg66D8jeOZ3zfFUBdYb/1lFNLm8HnUOYLOeEn8idpKWkb1j1zu9vQPQS cos24n8k99vrrU8RXcRk9QPwGp6f+g+elhhivMu+s+wXAsyZIqoChtQUjkviL2dd PYmlntX97w1rXNwWgamOJOnMmqEGybJsVnt4fV03qU7GUD5bvg3fmiCUokzkZ4oL QsZIuXzI3bmwbn2xDYxPE+XCLF+FBDrivkKVx51RxKjUpgMB6FEabG9QnWa7aVf6 sLd7tP27/y/kqAiV95ibB0VIXo3sHc03AwGV8r0PNa4SXypvuvVKST7Ldghwlr/Y xphkfR/uDQoAdVdvZ5gC =n41B -----END PGP SIGNATURE----- --zYM0uCDKw75PZbzx--