Date: Sun, 24 Apr 2016 18:27:33 +0200
From: Pavel Machek <pavel@denx.de>
To: Scott Bauer <sbauer@eng.utah.edu>
Cc: linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com,
        x86@kernel.org, ak@linux.intel.com, luto@amacapital.net,
        mingo@redhat.com, tglx@linutronix.de, wmealing@redhat.com,
        torvalds@linux-foundation.org,
        Abhiram Balasubramanian <abhiram@cs.utah.edu>,
        Scott Bauer <sbauer@plzdonthack.me>
Subject: Re: [PATCH v4 4/4] Documentation: SROP Mitigation: Add documentation
 for SROP cookies
Message-ID: <20160424162733.GF8880@amd>
References: <1459281207-24377-1-git-send-email-sbauer@eng.utah.edu>
 <1459281207-24377-5-git-send-email-sbauer@eng.utah.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1459281207-24377-5-git-send-email-sbauer@eng.utah.edu>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 7187
Lines: 249

Hi!

> index 0000000..ee17181
> --- /dev/null
> +++ b/Documentation/security/srop-cookies.txt
> @@ -0,0 +1,203 @@
> +         Sigreturn-oriented programming and its mitigation
> +
> +
> +A good write up can be found here: https://lwn.net/Articles/676803/
> +It covers much of what is outlined in this documentation.

Umm. I'd rather have good documentation here than on the web
somewhere.

> +If you're very curious you should read the SROP paper:
> +http://www.cs.vu.nl/~herbertb/papers/srop_sp14.pdf
> +
> +If you're here to learn how to disable SROP issue the following

", issue"?

> +Command:
> +
> +# echo 1 > /proc/sys/kernel/disable-srop-protection

Can we have reverse logic, having '.../srop-protection' file? Double
negatives are not intuitive...

> +============================ Overview ============================
> +
> +Sigreturn-oriented programming(SROP) is a new technique to control
> +a compromised userland process after successfully exploiting a bug.
> +
> +Signals are delivered to the process during context switches. The
> +kernel will setup a signal frame on the process' stack which
> +contains the saved state of the process prior to the context switch.
> +The kernel then gives control the the process' signal handler. Once
> +the process has delt with the signal it will call the sigreturn

dealt

> +system call. During the context switch into the kernel, the previous
> +state of where the process was executing prior to the delivery of
> +the signal is overwritten, hence why the kernel must save the the

hence why? the the?

> +state in a signal frame on the user's stack. The kernel will remove
> +the signal frame from the process' stack and continue execution
> +where the process left off.
> +
> +The issue with this signal delivery method is if an attacker can

"is: if"?

> +construct a fake signal frame on the compromised process' stack
> +and ROP into the sigreturn system call, they have the ability to
> +easily control the flow of execution by having the kernel return
> +execution to wherever the signal frame says to continue execution.
> +
> +More importantly, SROP makes an attackers job easier. Previously

attacker's?

> +attackers would have to search for ROP gadgets to get values into
> +registers then call mprotect or mmap to get some memory where they
> +could copy and execute shellcode. If the ROP gadgets didnt exist

didn't

> +that allowed setting up a call to those functions then the attackers
> +wouldn't be able to fully exploit the bug. With SROP however attackers

, however,

> +dont' have to search for ROP gadgets to get specific values into

don't

> +registers. The attacker would simply lay out the ucontext on the stack
> +as they choose then SROP into the mprotect or mmap call.

choose,

> +======================== Mitigating  SROP ========================
> +
> +In order to prevent SROP the kernel must remember or be able to derive
> +at runtime whether a sigreturn call it is currently processing is
> +in respose to a legitimate signal delivered by the kernel.

response.

> +During delivery of a signal the kernel will place the signal frame

, the kernel

> +with the saved process state on the stack. It will also place a cookie
> +above the signal frame.
> +
> +The cookie is a per-process secret xor'd with the address where it will
> +be stored. During a sigreturn the kernel will extract this cookie, and
> +then compare the extracted cookie against a new generated cookie:
> +(the per process secret xord with address where we extracted cookie from).

kill the ()s?

> +If the two cookies match, then the kernel has verified that it is handling
> +a sigreturn from a signal that was previously legitimately delivered.
> +If the cookies do not match up the kernel sends a SIGSEGV to the process,
> +terminating it.

up, the kernel.

Hmm. SIGSEGV does not neccessarily terminate a process, right? Which
register values will it use for the SIGSEGV handler?

> +After verifying the cookie, the kernel will zero out the cookie to prevent
> +any sort of leaking of the cookie.

delete 'any sort', because we know that cookie can leak, for example
due to threads sharing the mm?

> +This prevents SROP because it forces an attacker to know the cookie in order
> +to use SROP as an attack vector.

-> This makes SROP harder... ?

> +
> +
> +======================== Possible Issues  ========================

you may want to search for "  " in this document.

> +SROP protection will probably break any process or application which do

does.

> +some sort of checkpoint-restore in user space type things. As well as DOSEMU.
> +
> +
> +
> +===============================================================================
> +Inlined are two programs that exploit SROP:
> +
> +For 32bit:
> +
> +Compile with if you're using a 64bit kernel:
> +gcc -O0 -o srop_32 srop_32.c -g -fno-stack-protector -ffixed-ebp -ffixed-esp -m32 -DEMULATED_32
> +
> +or if you're already on a real 32bit kernel:
> +gcc -O0 -o srop_32 srop_32.c -g -fno-stack-protector -ffixed-ebp -ffixed-esp
> +

this should go to tools/ somewhere, no? 

> +When run without SROP protection it will exit gracefully, when SROP is
> +enabled it will terminate with a SIGSEGV.
> +
> +#include <stdlib.h>
> +#include <stdio.h>
> +#include <signal.h>
> +
> +void syscall(void)
> +{
> +  exit(1);
> +}
> +
> +void test2(void)
> +{
> +  register int esp asm("esp");
> +  register int ebp asm("ebp");
> +  struct sigcontext scon = { 0 };
> +
> +  scon.eax = 11;
> +  scon.ebx = 0x41;
> +  scon.ecx = 0;
> +  scon.edx = 0;
> +  scon.esp = scon.ebp = ebp;
> +  scon.eip = (int)syscall+6;
> +
> +#if defined EMULATED_32
> +  scon.fs = 0x00;
> +  scon.cs = 0x23;
> +  scon.ss = scon.ds = scon.es = 0x2B;
> +  scon.gs = 0x63;
> +#else
> +  scon.fs = 0x00;
> +  scon.cs = 0x73;
> +  scon.ss = scon.ds = scon.es = 0x7B;
> +  scon.gs = 0x33;
> +#endif
> +  esp = (int) &scon;
> +  asm("movl $119, %eax\n");//NR_SIGRETURN;
> +  asm("int $0x80\n");
> +}

Coding style. //.

> +For 64 bit:
> +
> +gcc -O0 -o srop srop.c -g  -fno-stack-protector -ffixed-rsp -ffixed-rbp
> +When run the program exits normally, with SROP protetction it terminates
> +with a segmentationf fault.

segmentation fault.


> +	REG_RIP,
> +	REG_EFL,
> +	REG_CSGSFS,/* Actually short cs, gs, fs, __pad0.  */

", "

> +void _exit_(void)
> +{
> +	exit(1);
> +}
> +
> +void test(void)
> +{
> +	struct ucontext ctx = { 0 };
> +	register unsigned long rsp asm("rsp");
> +	register unsigned long rbp asm("rbp");
> +	ctx.uc_mcontext.gregs[REG_RIP] = (unsigned long) _exit_ + 4;

Why + 4?

> +	ctx.uc_mcontext.gregs[REG_RSP] = rsp;
> +	ctx.uc_mcontext.gregs[REG_RBP] = rbp;

Umm. Does this work?

> +	ctx.uc_mcontext.gregs[REG_CSGSFS] = 0x002b000000000033;
> +	rsp = (unsigned long) &ctx;
> +	asm("movq $0xf,%rax\n");

", "? asm volatile? Clobbers?

> +	asm("syscall\n");

Make it single asm statemtent so that gcc does not play with you? Add
checking if syscall just returns failure?

Aha, -O0 above. So you already know the code is buggy...?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html